Geo: update geo_node_name to geo_site_name in gitlab.rb
Problem to solve
- Update the terminology in
gitlab.rb
- Follow this doc https://docs.gitlab.com/omnibus/settings/gitlab.yml.html
- We must support
geo_node_name
andgeo_site_name
both for a while and go through the deprecation/removal process.
Also do the same for charts: global.geo.nodeName
=> global.geo.siteName
How to contribute to the project 

- How to contribute to the GitLab project (development)
- Once you set up your GDK, please refer to this document to configure it to the Geo sites.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Sunjung Park added to epic &5725
added to epic &5725
- Sunjung Park changed the description
Compare with previous version changed the description
- Sunjung Park mentioned in merge request !65969 (merged)
mentioned in merge request !65969 (merged)
- 🤖 GitLab Bot 🤖 added automation:ml groupgeo labels
added automation:ml groupgeo labels
- Maintainer
This issue was automatically tagged with the label groupgeo by TanukiStan, a machine learning classification model, with a probability of 1.
If this label is incorrect, please tag this issue with the correct group label as well as automation:ml wrong to help me learn from my mistakes.
- Maintainer
Setting label(s) devopsenablement sectionenablement based on groupgeo.
- 🤖 GitLab Bot 🤖 added devopssystems sectioncore platform labels
added devopssystems sectioncore platform labels
- Michael Kozono mentioned in merge request !67914 (merged)
mentioned in merge request !67914 (merged)
- Michael Kozono changed title from Geo: update geo_node_name in gitlab.rb to Geo: update geo_node_name to geo_site_name in gitlab.rb
changed title from Geo: update geo_node_name in gitlab.rb to Geo: update geo_node_name to geo_site_name in gitlab.rb
- Michael Kozono changed the description
Compare with previous version changed the description
- Maintainer
@nhxnguyen
I found this one for transitioning togeo_site_name
. Collapse replies - Developer
Nice, thanks! Adding to workflowscheduling.
- Nick Nguyen added workflowscheduling label
added workflowscheduling label
- Nick Nguyen changed milestone to %Backlog
changed milestone to %Backlog
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- Michael Kozono changed the description
Compare with previous version changed the description
- Sampath Ranasinghe added workflowplanning breakdown + 1 deleted label and removed workflowscheduling label
added workflowplanning breakdown + 1 deleted label and removed workflowscheduling label
- Sampath Ranasinghe added priority3 label
added priority3 label
- Sunjung Park added UX scorecard-rec label
added UX scorecard-rec label
- 🤖 GitLab Bot 🤖 added 1 deleted label
added 1 deleted label
- Maintainer
All SUS-impacting issues need to have a proper severity label set. Please add a severity label, remove the automation:ux-missing-labels label, and then reply to this comment briefly explaining your reasoning for providing this severity.
If you are not the DRI for this area and would like help determining the best severity, please @ the appropriate person for assistance.
- 🤖 GitLab Bot 🤖 added automation:ux-missing-labels label
added automation:ux-missing-labels label
- Sunjung Park removed automation:ux-missing-labels label
removed automation:ux-missing-labels label
- Sunjung Park added severity4 label
added severity4 label
- Developer
Collapse replies - Author Developer
I was wondering if this is a good candidate for the Hacktoberfest, WDYT @sranasinghe
- Developer
Thanks for the suggestion @sunjungp
@dbalexandre @mkozono are there any surprises here that need be outlined for someone outside the Geo team to be able to work on this?
1 - Maintainer
@sranasinghe I don't think so.
1 1 - Maintainer
I added a link to https://docs.gitlab.com/omnibus/settings/gitlab.yml.html in the description.
2
- Sampath Ranasinghe added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Sunjung Park removed 1 deleted label
removed 1 deleted label
- 🤖 GitLab Bot 🤖 added 1 deleted label
added 1 deleted label
- Sunjung Park added Hacktoberfest Seeking community contributions labels
added Hacktoberfest Seeking community contributions labels
- Maintainer
@sunjungp thanks for adding the Seeking community contributions label!
This issue's description does not seem to have a section for "Implementation Guide". Please consider adding one, because it makes a big difference for contributors. This section can be brief but must have clear technical guidance, like:
- Hints on lines of code which may need changing
- Hints on similar code/patterns that can be leveraged
- Suggestions for test coverage
- Ideas for breaking up the merge requests into iterative chunks
This message was generated automatically. You're welcome to improve it.
- Sunjung Park removed automation:ml label
removed automation:ml label
- Sunjung Park added backend label
added backend label
- Sunjung Park changed the description
Compare with previous version changed the description
- Maintainer
We've removed the Seeking community contributions label because the workflow label indicates this issue is not ready.
- Michael Kozono changed the description
Compare with previous version changed the description
- Sampath Ranasinghe mentioned in issue gitlab-org/geo-team/discussions#5047 (closed)
mentioned in issue gitlab-org/geo-team/discussions#5047 (closed)
- Sampath Ranasinghe mentioned in issue gitlab-org/geo-team/discussions#5049 (closed)
mentioned in issue gitlab-org/geo-team/discussions#5049 (closed)
- Sampath Ranasinghe mentioned in issue gitlab-org/geo-team/discussions#5052 (closed)
mentioned in issue gitlab-org/geo-team/discussions#5052 (closed)
- Sampath Ranasinghe changed milestone to %15.8
changed milestone to %15.8
- Maintainer
@sranasinghe - please see the following guidance and update this issue.1 Error Please add typebug typefeature, typemaintenance and a subtype label to this issue. If you do not feel the purpose of this issue matches one of the types, you may apply the typeignore label to exclude it from type tracking metrics and future prompts.
- Sampath Ranasinghe added maintenanceusability typemaintenance labels
added maintenanceusability typemaintenance labels
- Sampath Ranasinghe mentioned in issue gitlab-org/geo-team/discussions#5055 (closed)
mentioned in issue gitlab-org/geo-team/discussions#5055 (closed)
- Developer
Moving to %15.9
- Sampath Ranasinghe changed milestone to %15.9
changed milestone to %15.9
- Sampath Ranasinghe mentioned in issue gitlab-org/geo-team/discussions#5068 (closed)
mentioned in issue gitlab-org/geo-team/discussions#5068 (closed)
- Zack Cuddy changed epic to &10069
changed epic to &10069
- 🤖 GitLab Bot 🤖 changed milestone to %15.11
changed milestone to %15.11
- 🤖 GitLab Bot 🤖 added missed:15.9 label
added missed:15.9 label