VSA deployment count via Dora API does not return any count
Summary
In !60927 (merged) the feature flag for enabling VSA deployment counts via the DORA metrics API was set to be enabled by default (via the :dora_deployment_frequency_in_vsa
flag), introduced in GitLab 13.12. While this feature flag is enabled, we no longer see any deployment or deployment frequency metrics. This occurs despite the deployed_to_production_at
field existing for our MRs in VSA and environments being named production
(meaning they should be production-tier by convention).
When disabling the :dora_deployment_frequency_in_vsa
the counts are once again shown.
Steps to reproduce
- On an instance with any tier other than Ultimate, create some deployments (using
environment: name: production
) in a project within a group. - Confirm that in the project value stream analytics, ensure you see the deployment/frequency count
- In the group which contains the project, open the Value Stream Analytics page. Observe that the deployment count/frequency is
-
.
Example Project
N/A affects self-hosted instances only.
What is the current bug behavior?
The group VSA page shows -
for deployments and deploy frequency, even if there are deployments.
What is the expected correct behavior?
The count of deployments and deployment frequency are shown.
Relevant logs and/or screenshots
Possible fixes
Other possible related MRs besides !60927 (merged) include:
- !60367 (merged)
- !59771 (merged)
- and possibly !61869 (merged)
One working theory was that this may occur because Dora metrics are a Ultimate-only feature. In ee/lib/gitlab/analytics/cycle_analytics/summary/group/deploy.rb
, the deployments_count
method should perhaps be guarded to check .feature_available?(:dora4_analytics)
if the count requires the feature availability.
As a workaround, affected users can disable the feature flag:
Feature.disable(:dora_deployment_frequency_in_vsa)