Use aggregated DORA API in VSA [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
This MR updates the deployment related metrics on the group value stream page to use an aggregated data source (DORA). This helps improving the consistency between the DORA metrics and Value Stream Analytics.
The change replaces the DeploymentsFinder
and uses the Dora::AggregateMetricsService
to calculate the deployment count within a given time range. DORA and VSA are both in the same "tier" (ultimate).
The change is behind a FF: dora_deployment_frequency_in_vsa
Note: the test cases are both running for the old and new ways of calculating deployment frequency and count.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because the change is behind FF.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #321005 (closed)