[Feature flag] Rollout of `sort_dependency_vulnerabilities`

Summary

This issue is to rollout the feature on production, that is currently behind the sort_dependency_vulnerabilities feature flag.

This feature fixes a bug that caused the dependency list to be sorted incorrectly. The feature increases the time complexity of the sorting implementation for the dependency list, so it was decided that it would be best to roll it out behind a feature flag to ensure that this doesn't negatively impact performance.

Owners

• Team: composition analysis
• Most appropriate slack channel to reach out to: #g_secure-composition-analysis
• Best individual to reach out to: Adam Cohen
• PM: Nicole Schwartz

Stakeholders

The Rollout Plan

• Rollout on GitLab.com for 1 week

Testing Groups/Projects/Users

• gitlab-org/gitlab project

Expectations

What are we expecting to happen?

Gather performance data over the course of 1 week

What might happen if this goes wrong?

If this feature negatively impacts performance, then we should disable it. At that point, we can decide whether to fix forward or revert the MR that introduces the new sorting code.

What can we monitor to detect problems with this?

TBD

Rollout Steps

Rollout on non-production environments

• Ensure that the feature MRs have been deployed to non-production environments.
  • /chatops run auto_deploy status <merge-commit-of-your-feature>
• Enable the feature globally on non-production environments.
  • /chatops run feature set <feature-flag-name> true --dev
  • /chatops run feature set <feature-flag-name> true --staging
• Verify that the feature works as expected. Posting the QA result in this issue is preferable.

Preparation before production rollout

• Ensure that the feature MRs have been deployed to both production and canary.
  • /chatops run auto_deploy status <merge-commit-of-your-feature>
• Check if the feature flag change needs to be accompanied with a change management issue. Cross link the issue here if it does.
• Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the @sre-oncall Slack alias.
• Ensure that documentation has been updated (More info).
• Announce on the feature issue an estimated time this will be enabled on GitLab.com.
• If the feature flag in code has an actor, enable it on GitLab.com for testing groups/projects.
  • /chatops run feature set --<actor-type>=<actor> <feature-flag-name> true
• Verify that the feature works as expected. Posting the QA result in this issue is preferable.

Global rollout on production

• Incrementally roll out the feature.
  • If the feature flag in code has an actor, perform actor-based rollout.
    • /chatops run feature set <feature-flag-name> <rollout-percentage> --actors
  • If the feature flag in code does NOT have an actor, perform time-based rollout (random rollout).
    • /chatops run feature set <feature-flag-name> <rollout-percentage>
  • Enable the feature globally on production environment.
    • /chatops run feature set <feature-flag-name> true
• Announce on the feature issue that the feature has been globally enabled.
• Cross-post chatops slack command to #support_gitlab-com. (more guidance when this is necessary in the dev docs) and in your team channel
• Wait for at least one day for the verification term.

(Optional) Release the feature with the feature flag

If you're still unsure whether the feature is deemed stable but want to release it in the current milestone, you can change the default state of the feature flag to be enabled. To do so, follow these steps:

• Create a merge request with the following changes. Ask for review and merge it.
  • Set the default_enabled attribute in the feature flag definition to true.
  • Create a changelog entry.
• Ensure that the above MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
  • /chatops run auto_deploy status <merge-commit>
• Close the feature issue to indicate the feature will be released in the current milestone.

WARNING: This approach has the downside that it makes it difficult for us to clean up the flag. For example, on-premise users could disable the feature on their GitLab instance. But when you remove the flag at some point, they suddenly see the feature as enabled and they can't roll it back to the previous behavior. To avoid this potential breaking change, use this approach only for urgent matters.

Release the feature

After the feature has been deemed stable, the clean up should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase.

• Create a merge request to remove <feature-flag-name> feature flag. Ask for review and merge it.
  • Remove all references to the feature flag from the codebase.
  • Remove the YAML definitions for the feature from the repository.
  • Create a changelog entry.
• Ensure that the above MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
  • /chatops run auto_deploy status <merge-commit>
• Close the feature issue to indicate the feature will be released in the current milestone.
• Clean up the feature flag from all environments by running these chatops command in #production channel:
  • /chatops run feature delete <feature-flag-name> --dev
  • /chatops run feature delete <feature-flag-name> --staging
  • /chatops run feature delete <feature-flag-name>
• Close this rollout issue.

Rollback Steps

• This feature can be disabled by running the following Chatops command:

/chatops run feature set <feature-flag-name> false

/cc @gonzoyumo @NicoleSchwartz @mkaeppler @fcatteau