Follow-up questions around specs for CI templates
Some follow-ups from !63144 (merged).
Should latest versions of CI templates also be verified in specs?
In !63144 (merged) the FFs to use the latest templates are disabled to avoid spec failures in https://gitlab.com/gitlab-org/gitlab/blob/d2e19edcea8be0b58e6a521422a3909219880d32/spec/lib/gitlab/ci/templates/templates_spec.rb#L67 and https://gitlab.com/gitlab-org/gitlab/blob/d2e19edcea8be0b58e6a521422a3909219880d32/ee/spec/lib/ee/gitlab/ci/templates/templates_spec.rb#L59.
Should these specs be changed to verify both the stable and latest versions, to ensure they're all correct?
The following discussion from !63144 (merged) should be addressed:
@toupeira started a discussion: (+1 comment) question: Why do we need to disable these here, but not
Jobs/Deploy
?🤔
Rename spec file to match template name
Rename ee/spec/lib/gitlab/ci/templates/Verify/browser_performance_testing_gitlab_ci_yaml_spec.rb
to ee/spec/lib/gitlab/ci/templates/Verify/browser_performance_gitlab_ci_yaml_spec.rb
.
The following discussion from !63144 (merged) should be addressed:
@toupeira started a discussion: (+1 comment) thought (non-blocking): I guess this file should properly be called
ee/spec/lib/gitlab/ci/templates/Verify/browser_performance_gitlab_ci_yaml_spec.rb
😉