Add a feature flag to try to redirect to latest template [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Originally raised in Slack https://gitlab.slack.com/archives/C01QGESL0UA/p1622703437010900
Regarding the breaking changes by latest=>stable template renewal in 14.0 (e.g. https://docs.gitlab.com/ee/development/cicd/templates.html#latest-version #232788 (closed)), it'd be helpful to introduce a feature flag in Gitlab::Template::GitlabCiYmlTemplate
to redirect the stable<=>latest versions. So that we can at least gradually rollout the latest content.
Today, we have the following latest templates that should replace its stable one:
shinya@shinya-B550-VISION-D:~/workspace/thin-gdk/services/rails/src$ find /home/shinya/workspace/thin-gdk/services/rails/src/lib/gitlab/ci/templates -iname *latest*
/home/shinya/workspace/thin-gdk/services/rails/src/lib/gitlab/ci/templates/Verify/Browser-Performance.latest.gitlab-ci.yml
/home/shinya/workspace/thin-gdk/services/rails/src/lib/gitlab/ci/templates/Jobs/Deploy.latest.gitlab-ci.yml
/home/shinya/workspace/thin-gdk/services/rails/src/lib/gitlab/ci/templates/Jobs/Browser-Performance-Testing.latest.gitlab-ci.yml
/home/shinya/workspace/thin-gdk/services/rails/src/lib/gitlab/ci/templates/Security/API-Fuzzing.latest.gitlab-ci.yml
/home/shinya/workspace/thin-gdk/services/rails/src/lib/gitlab/ci/templates/Security/DAST.latest.gitlab-ci.yml
/home/shinya/workspace/thin-gdk/services/rails/src/lib/gitlab/ci/templates/Terraform.latest.gitlab-ci.yml
/home/shinya/workspace/thin-gdk/services/rails/src/lib/gitlab/ci/templates/Terraform/Base.latest.gitlab-ci.yml
Screenshots (strongly suggested)
When the feature flag is disabled, the stable template is read
When the feature flag is enabled, the latest template is read
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team