Skip to content

Remove status checks from approval rules and update feature specs

This is the frontend implementation issue

Problem to solve

Status checks have been added to its own settings area rather than being a part of Merge request (MR) approval rules. We now need to remove the status checks functionality from MR approval rules, remove the status checks related feature specs, and add feature specs specific to the new status checks area.

Proposal

  1. Remove status checks as an approval rule option.
  2. Remove status checks specific feature specs from MR approval rules
  3. Add new feature specs for the new status checks area

Design

Screenshots
🆕 location
Status_checks
Modal - Modal -
Modal_-__failure Modal_-_valid

Is this a cross-stage feature?

🤝 groupcompliance groupsource code groupcode review

Implementation

I think this will be a weight of 2️⃣ due to the number of lines this will touch:

  1. Undo the changes made to approvals in #300973 (closed)
  2. Update the feature specs and add new ones for status checks

Follow-up: Look at moving similar code to a shared usage between approval rules and status checks