Skip to content

Resolve "Display security approval rules when creating a new project - Implement Vulnerability-Check/License-Check rows"

- requested to merge 229825-implement-rows into master

What does this MR do?

MR for #229825 (closed)

Implements default messaging for security related approval rules. Specifically License-Check and Vulnerability-Check

Feature flag

To enable run the following in a rails console:

Feature.enable(:approval_suggestions)

Feature flag removal follow up for next milestone

#235114 (closed)

Video Demo

https://youtu.be/sfPPXzia2Ss

Before

Screen_Shot_2020-08-10_at_6.31.20_AM

After

Screen_Shot_2020-08-10_at_6.21.49_AM

Screen_Shot_2020-08-10_at_6.22.00_AM

Screen_Shot_2020-08-10_at_6.22.23_AM

Screen_Shot_2020-08-10_at_6.22.29_AM

Screen_Shot_2020-08-10_at_6.22.42_AM

Screen_Shot_2020-08-10_at_6.22.47_AM

Screen_Shot_2020-08-10_at_6.22.53_AM

When job not configured

Screen_Shot_2020-08-10_at_6.23.15_AM

When both jobs not configured

Screen_Shot_2020-08-10_at_6.23.34_AM

When a user manually creates an approval rule even though the job is not configured (we still show the unconfigured row message)

Screen_Shot_2020-08-10_at_6.26.28_AM

Screen_Shot_2020-08-10_at_6.26.44_AM

Screen_Shot_2020-08-10_at_6.26.53_AM

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #229825 (closed)

Edited by -

Merge request reports

Loading