Resolve "Display security approval rules when creating a new project - Implement Vulnerability-Check/License-Check rows"
What does this MR do?
MR for #229825 (closed)
Implements default messaging for security related approval rules. Specifically License-Check
and Vulnerability-Check
Feature flag
To enable run the following in a rails console:
Feature.enable(:approval_suggestions)
Feature flag removal follow up for next milestone
Video Demo
Before
After
When job not configured
When both jobs not configured
When a user manually creates an approval rule even though the job is not configured (we still show the unconfigured row message)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #229825 (closed)
Edited by -