Skip to content
Snippets Groups Projects
New look: Off

Auto-devops sorting for production incremental manual rollout is different on pipelines page

    • Closed Issue created by David Wilkins @dwilkins

    Summary

    Auto-devops Incremental Rollout sorts differently on the pipelines page than it does on the view pipeline page

    Steps to reproduce

    • Create the most basic auto-devops project with $INCREMENTAL_ROLLOUT_ENABLED (or not specified) and INCREMENTAL_ROLLOUT_MODE = "manual" (I think this is the default). Use the Auto Devops defaults where possible.
    • I disabled the test phase, but I don't think that causes this problem.
    • Ensure the configuration
    • Get your deployments to staging working.
    • Click on the manual deployment stage button on the pipelines page
    • sorting will be incorrect (see attached video)
      • rollout 10%
      • rollout 100%
      • rollout 50%
      • rollout 75%
    • sorting should be:
      • rollout 10%
      • rollout 50%
      • rollout 75%
      • rollout 100%

    My .gitlab-ci.yml is:

    include:
  - template: Auto-DevOps.gitlab-ci.yml

variables:
  POSTGRES_ENABLED: "false"
  CODE_QUALITY_DISABLED: "true"
  TEST_DISABLED: "true"

staging:
  variables:
    K8S_SECRET_RAILS_ENV: "staging"

production:
  variables:
    K8S_SECRET_RAILS_ENV: "production"

cache:
  key: ${CI_COMMIT_REF_SLUG}
  paths:
    - vendor/ruby

    Example Project

    I may be able to create a project on GitLab.com for this, but I haven't.

    What is the current bug behavior?

    • sorting for production manual rollout will be incorrect (see attached video)
      • rollout 10%
      • rollout 100%
      • rollout 50%
      • rollout 75%

    What is the expected correct behavior?

    • sorting for production manual rollout should be:
      • rollout 10%
      • rollout 50%
      • rollout 75%
      • rollout 100%

    Relevant logs and/or screenshots

    incorrect-rollout-percentage-sorting

    Output of checks

    This bug happens locally

    Results of GitLab environment info

    Expand for output related to GitLab environment info 
    System information
System:
Current User:	dwilkins
Using RVM:	yes
RVM Version:	1.29.9
Ruby Version:	2.6.3p62
Gem Version:	3.0.4
Bundler Version:1.17.3
Rake Version:	12.3.2
Redis Version:	5.0.5
Git Version:	2.22.0
Sidekiq Version:5.2.7
Go Version:	go1.12.7 darwin/amd64
    

    GitLab information
Version:	12.2.0-pre
Revision:	463925f93c1
Directory:	/Users/dwilkins/source/gitlab/gdk-ce-ad/gitlab
DB Adapter:	PostgreSQL
DB Version:	10.9
URL:		https://23815.qa-tunnel.gitlab.info
HTTP Clone URL:	https://23815.qa-tunnel.gitlab.info/some-group/some-project.git
SSH Clone URL:	ssh://dwilkins@localhost:2222/some-group/some-project.git
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers:
    

    GitLab Shell
Version:	9.4.1
Repository storage paths:
    • default: /Users/dwilkins/source/gitlab/gdk-ce-ad/repositories GitLab Shell path: /Users/dwilkins/source/gitlab/gdk-ce-ad/gitlab-shell Git: /usr/local/bin/git

    Results of GitLab application Check

    Expand for output related to the GitLab application check 
    Check GitLab API access: OK
Redis available via internal API: OK
Access to /Users/dwilkins/source/gitlab/gdk-ce-ad/.ssh/authorized_keys: OK
gitlab-shell self-check successful
    

    Checking GitLab Shell ... Finished
    

    Checking Gitaly ...
    

    Gitaly: ... default ... OK
    

    Checking Gitaly ... Finished
    

    Checking Sidekiq ...
    

    Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1
    

    Checking Sidekiq ... Finished
    

    Checking Incoming Email ...
    

    Incoming Email: ... Reply by email is disabled in config/gitlab.yml
    

    Checking Incoming Email ... Finished
    

    Checking LDAP ...
    

    LDAP: ... LDAP is disabled in config/gitlab.yml
    

    Checking LDAP ... Finished
    

    Checking GitLab App ...
    

    Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... no
Try fixing it:
sudo chmod 700 /Users/dwilkins/source/gitlab/gdk-ce-ad/gitlab/public/uploads
For more information see:
doc/install/installation.md in section "GitLab"
Please fix the error above and rerun the checks.
Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet)
Init script exists? ... no
Try fixing it:
Install the init script
For more information see:
doc/install/installation.md in section "Install Init Script"
Please fix the error above and rerun the checks.
Init script up-to-date? ... can't check because of previous errors
Projects have namespace: ...
2/1 ... yes
2/2 ... yes
3/3 ... yes
4/4 ... yes
5/5 ... yes
6/6 ... yes
7/7 ... yes
8/8 ... yes
1/9 ... yes
1/10 ... yes
1/11 ... yes
34/12 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.3)
Git version >= 2.22.0 ? ... yes (2.22.0)
Git user has default SSH configuration? ... no
Try fixing it:
mkdir ~/gitlab-check-backup-1566417432
sudo mv /Users/dwilkins/.ssh/config~ ~/gitlab-check-backup-1566417432
sudo mv /Users/dwilkins/.ssh/config ~/gitlab-check-backup-1566417432
sudo mv /Users/dwilkins/.ssh/id_rsa ~/gitlab-check-backup-1566417432
sudo mv /Users/dwilkins/.ssh/id_rsa.pub ~/gitlab-check-backup-1566417432
sudo mv /Users/dwilkins/.ssh/google_compute_engine.pub ~/gitlab-check-backup-1566417432
sudo mv /Users/dwilkins/.ssh/google_compute_engine ~/gitlab-check-backup-1566417432
sudo mv /Users/dwilkins/.ssh/google_compute_known_hosts ~/gitlab-check-backup-1566417432
For more information see:
doc/ssh/README.md in section "SSH on the GitLab server"
Please fix the error above and rerun the checks.
Active users: ... 26
    

    Checking GitLab App ... Finished
    

    Checking GitLab subtasks ... Finished

    Possible fixes

    I haven't looked

    Designs

    Child items ...

    • Activity

    Please register or sign in to reply