When feature flag is removed, users will be able to navigate to individual Jira issues from within GitLab.
What might happen if this goes wrong?
Users are unable to view Jira issues as they expect
Existing functionality should remain unaffected
What can we monitor to detect problems with this?
Sentry, Kibana
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
tom-q-test/my-awesome-proj project
Roll Out Steps
Enable on staging (/chatops run feature set jira_issues_show_integration true --staging)
Test on staging
Ensure that documentation has been updated (!56182 (merged))
Enable on GitLab.com for individual groups/projects listed above and verify behaviour (/chatops run feature set --project=gitlab-org/gitlab jira_issues_show_integration true)
Given the nature of the frontend changes, @justin_ho and I are sufficiently confident in the additions to enable the feature flag by default (given the fix to Jira issue comment timestamps lands in production: #324300 (closed))
Question: @arturoherrero do you feel the same way about the backend changes? It's totally fine if not - I can go ahead and update the docs MR (!56182 (merged)) and we will ship it disabled by default.
Note that we will aim to enable the feature flag on production in the next 12 hours, in the event that the Production Change Lock is removed at 9am UTC 16th March.
@tomquirk Yes, I'm confident with the backend. In the end, the frontend consumes the payload from the backend, so if you are confident with the frontend, that implies that the backend behaves as expected.
The only problem that I see is the bug with the timestamps #324300 (closed) for self-hosted GitLab instances, the fix is not going to be available for them in %13.10 causing 500 errors in some cases.
Isn't the bug for timestamps already merged? And since we are not at the cut-off for deployment, it should be included in %13.10 right? Unless I am misreading your comment.
Thinking again, we are safe with self-hosted instances because they have default_enabled: false. When we do default_enabled: true in !56182 (merged), the fix is already in place. So all good!
What I'm not sure about is if !56182 (merged) will arrive for %13.10 or we are already outside the milestone.
Sounds good folks. I will aim to enable the feature flag on production ASAP.
I think I was overly optimistic with !56182 (merged) - there is still a chance it will make it, but if it doesn't, the docs on docs.gitlab.com will not reflect the fact that default_enabled: false for self-managed
I will split up the MR so that the docs and the default_enabled: true change are separate. If default_enabled: truedoes end up making it, then we can update the docs to reflect this afterwards
If not, we'll have the opportunity to gather feedback on GitLab.com prior to enabling by default
marked the checklist item https://gitlab.com/tom-q-test/my-awesome-proj (/chatops run feature set --project=tom-q-test/my-awesome-proj jira_issues_show_integration true) as completed
Tom Quirkmarked the checklist item Enable on GitLab.com for individual groups/projects listed above and verify behaviour (/chatops run feature set --project=gitlab-org/gitlab jira_issues_show_integration true) as completed
marked the checklist item Enable on GitLab.com for individual groups/projects listed above and verify behaviour (/chatops run feature set --project=gitlab-org/gitlab jira_issues_show_integration true) as completed
Tom Quirkchanged the descriptionCompare with previous version
The feature will most likely be disabled by default in the %13.10 release. Self-managed users are able to manually enable the feature flag on their GitLab instance. I will update the docs MR !56182 (merged) to reflect this.
Justin Ho Tuan Duongmarked the checklist item Enable on GitLab.com by running chatops command in #production (/chatops run feature set jira_issues_show_integration true) as completed
marked the checklist item Enable on GitLab.com by running chatops command in #production (/chatops run feature set jira_issues_show_integration true) as completed