Upgrade Docker image of License Compliance to Node.js 14 LTS
Do the following docker images need node.js updates?
- registry.gitlab.com/gitlab-org/security-products/analyzers/license-finder:latest
unclear in - #294180 (closed) if they were excluded because not needed
This is blocked by #298720 (closed) (broken master).
Proposal
Update asdf
configuration of license-finder to enable Node.js 14, and make it the default version.
Implementation plan
-
open a MR that updates license-finder to Node 14 - add Node 14.x to config/software/asdf_nodejs.rb
- make that the default version of Node in config/files/.tool-versions
Older versions of Node.js are NOT removed from asdf configuration, to ensure backward compatibility.
See comment
See gitlab-org/security-products/analyzers/license-finder!18 (merged) for a similar change to support a new version of Go.
Testing
Currently the test
stage of license-finder doesn't check for compatibility with various versions of Node, Go, Java, etc. See CI config.
Documentation
The documentation doesn't say what the default version of Node is, so it doesn't need to be updated. That said, it uses node 12.6.3 as an example, and we might want to change that to node 14.x.
Node is not mentioned in the supported languages and package managers. TODO: create an issue about updating that list.