HipChat project service removal
Hipchat was discontinued by Atlassian in 2018, and support reached end-of-life in June of 2020.
We originally planned to remove it in %14.0, but due to #325851 (closed) we had to make it non-operational in %13.11. The gem and some code have been removed in !57434 (merged) and !57556 (merged). There are still some tasks that we have to do:
-
Remove
HipchatService
integration code (model/controller/service/view/api) %13.12 !59769 (merged) -
Remove
HipchatService
database records from theservices
table %13.12 !59769 (merged) -
Cleanup remaining
HipchatService
code %14.0 !62222 (merged) - Verify product intelligence https://gitlab.com/gitlab-data/analytics/-/issues/8603 and remove YAML files !59000 (merged)
Previous description
We removed this in gitlab-foss#52424 (closed) but it caused some issues as on-prem HipChat is still available. gitlab-foss#60042 (closed) is the issue where we added this back.
Designs
- Show closed items
- Issue#324228BacklogCategory:SAST GitLab Core GitLab Premium GitLab Ultimate [deprecated] Accepting merge requests backend devops application security testing group static analysis section sec type feature
- Epicgitlab-org#130501219Feb 10 – Sep 13, 2024Category:SAST devops application security testing feature consolidation group static analysis section sec type feature
- Issue#439046BacklogCategory:SAST backend customer devops application security testing group static analysis section sec
- Issue#425084BacklogCategory:SAST devops application security testing group static analysis section sec type feature workflow planning breakdown
- Issue#373117515.9Category:SAST Deliverable Track Health Status [DEPRECATED] devops application security testing feature enhancement group static analysis section sec type feature workflow complete
- Issue#36295816.0Category:SAST Deliverable GitLab Free GitLab Premium GitLab Ultimate backend customer devops application security testing documentation group static analysis missed-deliverable missed:15.7 missed:15.8 section sec type feature workflow complete
- Issue#36284915.10Category:SAST Deliverable [deprecated] Accepting merge requests devops application security testing feature consolidation group static analysis section sec type feature workflow complete
- Issue#35266615.4Category:SAST GitLab Free GitLab Premium GitLab Ultimate backend devops application security testing documentation group static analysis missed:15.2 missed:15.3 section sec type feature
- Issue#34725815.4Category:SAST backend customer devops application security testing feature enhancement group static analysis section sec type feature workflow production
- Issue#335221BacklogCategory:SAST [deprecated] Accepting merge requests devops application security testing group static analysis maintenance workflow section sec type maintenance
- Issue#33406514.02Category:SAST backend devops application security testing group static analysis section sec type maintenance workflow in dev
- Epicgitlab-org#544064Feb 18 – Apr 17, 2021Category:SAST devops application security testing group static analysis section sec type feature
- EpicClosedgitlab-org#56881013Jan 18 – Jun 17, 2021Category:SAST backend devops application security testing group static analysis section sec
- Issue#331801BacklogCategory:SAST [deprecated] Accepting merge requests backend devops application security testing feature enhancement group static analysis section sec type feature
- Issue#330578BacklogCategory:SAST Product Feedback SAST: New Scanner [deprecated] Accepting merge requests customer devops application security testing group static analysis section sec
- Epicgitlab-org#57971015Apr 18 – May 17, 2021Category:SAST [deprecated] Accepting merge requests backend devops application security testing feature enhancement group static analysis section sec type feature
- Issue#327236BacklogCategory:SAST [deprecated] Accepting merge requests backend devops application security testing feature enhancement group static analysis section sec type feature
- Issue#321204BacklogCategory:SAST [deprecated] Accepting merge requests backend devops application security testing group static analysis section sec type feature
- Issue#118496BacklogCategory:SAST SAST: Integrate customer devops application security testing group static analysis section sec type feature workflow start
- Issue#26206813.11Category:SAST Deliverable Discovery SAST: Integrate [deprecated] Accepting merge requests backend devops application security testing group static analysis missed-deliverable missed:13.10 missed:13.9 section sec type feature workflow planning breakdown
- IssueClosed#300486BacklogCategory:SAST [deprecated] Accepting merge requests auto updated backend devops application security testing group static analysis section sec type feature
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Sean McGivern changed milestone to %12.1
changed milestone to %12.1
- Sean McGivern added Plan [DEPRECATED] backend devopsplan typefeature + 1 deleted label
added Plan [DEPRECATED] backend devopsplan typefeature + 1 deleted label
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- Sean McGivern changed weight to 3
changed weight to 3
- Sean McGivern changed milestone to %12.2
changed milestone to %12.2
- Author Contributor
Turns out this one is easy to push back
- Sean McGivern changed milestone to %12.5
changed milestone to %12.5
- 🤖 GitLab Bot 🤖 changed milestone to %12.5
changed milestone to %12.5
- 🤖 GitLab Bot 🤖 changed weight to 3
changed weight to 3
- Maintainer
From https://www.atlassian.com/partnerships/slack/faq:
What happens to existing Stride & Hipchat customers?
Existing groups will be able to continue to add users and use Stride and Hipchat Cloud products until February 15th, 2019. Note: We are strongly encouraging customers who want to retain their Stride and Hipchat data to begin exporting their data in January 2019, as well as exporting any associated app data. The last day to export data from Stride and Hipchat Cloud is March 15, 2019.
Existing Hipchat Data Center & Hipchat Server customers will have support through the end of their license period. We will provide a preferred migration path to Slack to all customers to ensure a smooth and simple transition.
This could be a while...
Edited by Thong Kuah Collapse replies - Maintainer
@tkuah From https://confluence.atlassian.com/hc/hipchat-server-faq-702714980.html:
As of July 2018, all HipChat Server and HipChat Data Center licenses will only be renewed up until the July 26th, 2019 expiration date. No licenses will be issued beyond this date.
but at the same time:
HipChat end-of-life dates (which are separate from license expiration) can be found below:
Hipchat Data Center (v3.0): June 22nd, 2019 Hipchat Data Center (v3.1): September 26th, 2019 Hipchat Server (v2.1): December 8th, 2018 Hipchat Server(v2.2): May 30th, 2019 Hipchat Server (v2.4): June 30th, 2020
- Author Contributor
Thanks for the updates! I think the backlog is the place for this right now.
- Sean McGivern changed milestone to %Backlog
changed milestone to %Backlog
- 🤖 GitLab Bot 🤖 added 1 deleted label
added 1 deleted label
- 🤖 GitLab Bot 🤖 removed 1 deleted label
removed 1 deleted label
- Lukas Eipert changed milestone to %13.12
changed milestone to %13.12
- Lukas Eipert added Category:Integrations groupecosystem [DEPRECATED] labels and removed Plan [DEPRECATED] [deprecated] Accepting merge requests labels
added Category:Integrations groupecosystem [DEPRECATED] labels and removed Plan [DEPRECATED] [deprecated] Accepting merge requests labels
- Maintainer
Setting milestone to %14.0. We should deprecate though soon.
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- Lukas Eipert added devopscreate label and removed devopsplan label
added devopscreate label and removed devopsplan label
- 🤖 GitLab Bot 🤖 added sectiondev label
added sectiondev label
- Patrick Deuley added priority2 label
added priority2 label
- Sean McGivern mentioned in issue #325838 (closed)
mentioned in issue #325838 (closed)
- Patrick Deuley mentioned in merge request gitlab-com/www-gitlab-com!78133 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!78133 (merged)
- Maintainer
Deprecation post for %13.11: gitlab-com/www-gitlab-com!78133 (merged)
Collapse replies - Maintainer
- Contributor
Yeah, I don't think that's strictly necessary. This product EOL'd almost a year ago, and unless you have backups of the installation source, it's no longer available whatsoever.
We do still have some tiny usage on it, and between that and the length past it's expiration date, I feel totally comfortable pulling the plug.
- Maintainer
@deuley Removing the hipchat gem may alleviate a high priority issue #325851 (closed). Is it on the table we could remove this integration now rather than follow a deprecation, or is that something we should not consider?
cc @tkuah who is looking into this.
- Arturo Herrero mentioned in issue #325851 (closed)
mentioned in issue #325851 (closed)
- Arturo Herrero assigned to @arturoherrero
assigned to @arturoherrero
- Maintainer
I'm assigning this to myself to start thinking about the work needed here. From the top of my mind:
- UI deprecation banner on the Hipchat integration page (optional)
- Remove
HipchatService
records from theservices
table - Remove the HipChat integration code (model/controller/service/view/api)
Collapse replies - Maintainer
- Remove any fork, override, or code required from the mimemagic dependency #325851 (comment 536913646).
- Maintainer
@arturoherrero - Please see #325851 (comment 537153041) from @deuley
I think the minimum we need is remove the
hipchat
gem, so that is what I will do now. - Maintainer
- Maintainer
!57434 (merged) has disabled the service (made its execute method do nothing) so this issue is now a chore task to remove it entirely (could be in %13.11 or %14.0) @deuley
Edited by Luke Duncalfe 2
- Arturo Herrero changed the description
Compare with previous version changed the description
- Thong Kuah assigned to @tkuah
assigned to @tkuah
- Thong Kuah mentioned in merge request !57434 (merged)
mentioned in merge request !57434 (merged)
- 🤖 GitLab Bot 🤖 removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- Thong Kuah unassigned @tkuah
unassigned @tkuah
- Luke Duncalfe mentioned in issue #325924 (closed)
mentioned in issue #325924 (closed)
- Maintainer
Yeah, we can remove the rest of the code now or soonish. I think that's backend only.
@deuley has already prepared a release post item: gitlab-com/www-gitlab-com!78133 (merged), so I don't think we need an in-product UI banner.
Edited by Lukas Eipert - Maintainer
@justin_ho Assigning you to double check that we do not have anything hipchat specific in the frontend.
Collapse replies - Maintainer
For starters, we have
HipChat
in the list of integrations with no indication that it's deprecated. Since I see that the backend was already removed (due to themimemagic
issue), I guess the only path forward is to remove it completely asap. Will go ahead and create an MR for this. - Maintainer
Thanks @justin_ho for !57556 (merged), I'll take a look ;)
- Maintainer
There is no frontend specific code for HipChat integration. Thanks @justin_ho for checking that!
I'll continue with this issue
- Lukas Eipert assigned to @justin_ho
assigned to @justin_ho
- Amy Qualls marked this issue as related to #325924 (closed)
marked this issue as related to #325924 (closed)
- Amy Qualls mentioned in merge request !57546 (merged)
mentioned in merge request !57546 (merged)
- Justin Ho Tuan Duong added deprecation label
added deprecation label
- Justin Ho Tuan Duong created merge request !57556 (merged) to address this issue
created merge request !57556 (merged) to address this issue
- Justin Ho Tuan Duong mentioned in merge request !57556 (merged)
mentioned in merge request !57556 (merged)
- Arturo Herrero set weight to 3
set weight to 3
- Arturo Herrero added workflowin dev label
added workflowin dev label
- Arturo Herrero set weight to 5
set weight to 5
- Arturo Herrero unassigned @justin_ho
unassigned @justin_ho
- Amy Qualls mentioned in merge request !57851 (merged)
mentioned in merge request !57851 (merged)
- Amy Qualls mentioned in merge request gitlab-docs!1643 (merged)
mentioned in merge request gitlab-docs!1643 (merged)
- Amy Qualls mentioned in merge request gitlab-docs!1651 (closed)
mentioned in merge request gitlab-docs!1651 (closed)
- Arturo Herrero changed the description
Compare with previous version changed the description
- Arturo Herrero changed the description
Compare with previous version changed the description
- Lukas Eipert changed title from Remove HipChat project service to HipChat project service removal
changed title from Remove HipChat project service to HipChat project service removal
- Lukas Eipert changed the description
Compare with previous version changed the description
- Piotr Skorupa mentioned in issue #322604 (closed)
mentioned in issue #322604 (closed)
- Matt Nohr added Deliverable label
added Deliverable label
- Marcel Amirault mentioned in issue #300600 (closed)
mentioned in issue #300600 (closed)
- Arturo Herrero mentioned in merge request !59769 (merged)
mentioned in merge request !59769 (merged)
- Arturo Herrero changed the description
Compare with previous version changed the description
- Piotr Skorupa mentioned in merge request !59779 (merged)
mentioned in merge request !59779 (merged)
- Maintainer
@arturoherrero @leipert I've noticed that due to removal of Hipchat from
Service::SERVICE_NAMES
in !57556 (merged) we're now missing a bunch of metrics in Usage Ping, because we were building them at runtime from that name list:"counts.groups_hipchat_active", "counts.groups_inheriting_hipchat_active", "counts.instances_hipchat_active", "counts.projects_hipchat_active", "counts.projects_inheriting_hipchat_active", "counts.templates_hipchat_active"
This is a bit unexpected as the metric definitions are supposed to be marked as
deprecated
first and only then removed.To mitigate this, I've created a MR to set these metrics as
removed
and I plan to notify the Data team, since this might break some Sisense dashboards if the data was used in any of them.Sorry for the confusion! If you plan some more project service removals like this, please have this in mind.
I'm currently working on a spec suite that will check for such changes to prevent this from the happening in the future. 2 2 Collapse replies - Maintainer
Hi @pskorupa, thanks for the feedback. We didn't have a plan to remove of HipChat integration as we need to remove it because of the issue with the mimemagic dependency #325851 (closed). I tried to create a quick plan #27954 (comment 536911972) but other people were also working on removing more things. Also product intelligence recently changed the process related to the usage data (eg. we use YAML files) but in any case, we should take the product analytics into account when removing an integration.
I cannot see any changes at the moment in !59779 (merged) but we are probably working on the same thing at the same time. Can you take a look at !59769 (merged), please?
1 - Maintainer
@arturoherrero Thank you for the context! There should now be changes in !59779 (merged).
Unfortunately, removing the metric files altogether in !59769 (merged) is not correct, as we deprecate metrics and change their statuses instead of removing their definition files. We haven't finalized the deprecation process yet, but that's the gist of it.
- Maintainer
@pskorupa Thanks, OK I'm not going to touch any of these files in !59769 (merged).
Do you have an issue in the GitLab Data Team project that we can link in the description? Otherwise, I can create the issue as specified in !59000 (merged).
1 - Maintainer
@arturoherrero Yes, I've already created one - https://gitlab.com/gitlab-data/analytics/-/issues/8603
1
- Arturo Herrero changed the description
Compare with previous version changed the description
- Arturo Herrero changed the description
Compare with previous version changed the description
- Arturo Herrero marked the checklist item Remove
HipchatService
integration code (model/controller/service/view/api) %13.12 as completedmarked the checklist item Remove
HipchatService
integration code (model/controller/service/view/api) %13.12 as completed - Arturo Herrero marked the checklist item Remove
HipchatService
database records from theservices
table %13.12 as completedmarked the checklist item Remove
HipchatService
database records from theservices
table %13.12 as completed - Arturo Herrero changed milestone to %14.0
changed milestone to %14.0
- Arturo Herrero changed the description
Compare with previous version changed the description
- Aric Buerer mentioned in issue gitlab-com/support/support-team-meta#3380 (closed)
mentioned in issue gitlab-com/support/support-team-meta#3380 (closed)
- Arturo Herrero marked the checklist item Verify product intelligence https://gitlab.com/gitlab-data/analytics/-/issues/8603 and remove YAML files !59000 (merged) as completed
marked the checklist item Verify product intelligence https://gitlab.com/gitlab-data/analytics/-/issues/8603 and remove YAML files !59000 (merged) as completed
- Maintainer
I'm reducing the weight to 1 for the remaining work.
- Arturo Herrero set weight to 1
set weight to 1
- Arturo Herrero added maintenancerefactor + 1 deleted label
added maintenancerefactor + 1 deleted label
- Arturo Herrero mentioned in merge request !62218 (merged)
mentioned in merge request !62218 (merged)
- Arturo Herrero changed the description
Compare with previous version changed the description
- Arturo Herrero mentioned in merge request !62222 (merged)
mentioned in merge request !62222 (merged)
- Arturo Herrero added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Arturo Herrero mentioned in issue #15491 (closed)
mentioned in issue #15491 (closed)
- Arturo Herrero mentioned in issue #15613 (closed)
mentioned in issue #15613 (closed)
- Arturo Herrero mentioned in issue #15902 (closed)
mentioned in issue #15902 (closed)
- Arturo Herrero mentioned in issue #24422 (closed)
mentioned in issue #24422 (closed)
- Arturo Herrero mentioned in commit 06c9bf5c
mentioned in commit 06c9bf5c
- Arturo Herrero marked the checklist item Cleanup remaining
HipchatService
code %14.0 !62222 (merged) as completedmarked the checklist item Cleanup remaining
HipchatService
code %14.0 !62222 (merged) as completed - Maintainer
With !62222 (merged) as the last merge request of the series, we can say that HipChat has been completely removed.
- Arturo Herrero closed
closed
- Arturo Herrero mentioned in commit 61917b00
mentioned in commit 61917b00
- 🤖 GitLab Bot 🤖 added 1 deleted label and removed devopscreate label
added 1 deleted label and removed devopscreate label
- Arturo Herrero mentioned in merge request !71286 (merged)
mentioned in merge request !71286 (merged)
- Arturo Herrero mentioned in issue #379197 (closed)
mentioned in issue #379197 (closed)
- 🤖 GitLab Bot 🤖 added devopsmanage label and removed 1 deleted label
added devopsmanage label and removed 1 deleted label
- Arturo Herrero mentioned in merge request !102394 (merged)
mentioned in merge request !102394 (merged)