Adjust the Minimum Word Count Danger Rule
Description
As discussed in the 2020-10-14 Engineering Staff Meeting the 3 word minimum is presenting barriers to Community Contributions now that pipelines are run from Forked Projects. We want to balance raising the bar with barriers to contributions and we welcome feedback on this.
The 3 word subject danger rule was originally set to fail with 28b56b71 to ensure enough context to troubleshoot using git log
is available. This is especially helpful when diagnosing an incident to see what might be affected.
When contributors use the default message from the WebIDE the Danger rule for Subject commits words and they are not easily able to fix in the WebIDE or a web tool. There has been opposition to modify the product for a GitLab project best practice #211673 (comment 307237061) so this proposal is to adjust the Danger rule.
Proposal
-
Relax the minimum words in subject Danger Rule to a warning from a failure: !45259 (merged) -
Add reviewer guidelines to ensure that feedback on Commit message context is provided: !46372 (merged)
Questions
- Is it possible to determine if the commit is sourced from WebIDE or non-WebIDE commit?
- Is there a measure that we should consider monitoring with this change?