Geo: Package files view not working by default
Problem
The Admin > Geo > Replication > Package files view (which is enabled by default because :geo_package_file_replication is enabled by default) has an error because it cannot access the GraphQL field unless the feature is explicitly and manually enabled.
Background
The feature flag :geo_package_file_replication is enabled by default because we have released the feature. The feature flag check remains, so that replication can be quickly and easily disabled in case a customer does not need to replicate this resource, or in case there is a serious bug or infrastructure problem causing excessive replication errors.
At the moment, there is no way to specify that the GraphQL field's feature flag should default enabled. Additionally, there is no need to disable the GraphQL API field, regardless of this feature flag, now that the feature is released. It just exposes the package_file_registry table.
When we defaulted package file replication on in 13.1 !34702 (merged), we should have permanently enabled the corresponding GraphQL field.
(We could modify GitLab's GraphQL code to allow us to default the field on, but the purpose of leaving these SSF feature flags in and defaulting them on is to allow disabling of replication. The GraphQL field does not need to be disableable.)
Workaround
- Enter Rails console
sudo gitlab-rails console - Run
Feature.enable(:geo_package_file_replication)
Proposal
Permanently enable the package_file_registries GraphQL field.