Skip to content

Deleting deploy keys does not inform the user if in use

Release Notes

In this release, we have added an additional safety measure to warn users that a deploy key is in use before deleting the key. This will help prevent accidentally breaking workflows of that project.

Problem to solve

Follow up from #30769 (comment 384759901)

Whenever a deploy key is about to be deleted, if that deploy key is currently assigned to a protected branch: deleting this key may disable users to do their CI/CD operations which involved accessing their protected branch.

Intended users

User experience goal

Users should be notified of the fact that they might be invalidating CI configurations when deleting a deploy key.

Proposal

When deleting a deploy key we should update the modal that is summoned up with a new GlModal and give it the following copy:

  • Title: Do you want to delete this deploy key?
  • Body: Are you sure you want to delete this deploy key? If anything is still using this key, it will stop working.
  • Actions:
    • Tertiary button with label Cancel
    • Primary danger button with label Delete deploy key

Further details

Permissions and Security

Documentation

Availability & Testing

What does success look like, and how can we measure that?

What is the type of buyer?

Is this a cross-stage feature?

Links / references

Edited by Orit Golowinski