Support parenthetical expressions in `rules:if`
Problem to solve
The if
syntax within rules is nice, but a lack of parentheses makes complex expressions impossible to write.
Intended users
User experience goal
Proposal
Add support for () in expressions to allow for more complex evaluation. Example:
rules:
- if: ($CI_COMMIT_BRANCH == "master" || $CI_COMMIT_BRANCH == "develop") && $MY_VARIABLE
Further details
Permissions and Security
Documentation
Availability & Testing
What does success look like, and how can we measure that?
What is the type of buyer?
Is this a cross-stage feature?
Links / references
Designs
- Show closed items
Relates to
- #29297Backlog
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Jason Yavorska changed milestone to %13.3
changed milestone to %13.3
- Jason Yavorska added CI rules label
added CI rules label
- Jason Yavorska assigned to @ayufan
assigned to @ayufan
- Jason Yavorska changed title from Support paranthetical expressions in
rules:if
to Support parenthetical expressions inrules:if
changed title from Support paranthetical expressions in
rules:if
to Support parenthetical expressions inrules:if
- Jason Yavorska changed the description
Compare with previous version changed the description
- Author Contributor
@thaoyeager this one is also appearing in your release outside of planning because it already comes with an MR being worked on by @ayufan
1 - Jason Yavorska added workflowin dev label
added workflowin dev label
- Jason Yavorska mentioned in merge request gitlab-com/www-gitlab-com!57292 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!57292 (merged)
- Marcel Amirault added documentation label
added documentation label
- Kamil Trzciński mentioned in merge request !37574 (merged)
mentioned in merge request !37574 (merged)
- Fabio Pitino mentioned in commit 2fad1023
mentioned in commit 2fad1023
- Fabio Pitino closed with merge request !37574 (merged)
closed with merge request !37574 (merged)
- Cheryl Li mentioned in issue #15170 (closed)
mentioned in issue #15170 (closed)
- Cheryl Li mentioned in merge request gitlab-com/www-gitlab-com!57283 (closed)
mentioned in merge request gitlab-com/www-gitlab-com!57283 (closed)
- Cheryl Li reopened
reopened
- Maintainer
@fabiopitino I assume that given the MR actually addressed this issue in its entirety. Do you mind reviewing the workflow label here? I will preemptively put it in workflowverification for now. Thanks!
- Cheryl Li added workflowverification label and removed workflowin dev label
added workflowverification label and removed workflowin dev label
- Author Contributor
@cheryl.li is this live on gitlab.com now then?
Collapse replies - Maintainer
@jyavorska @cheryl.li this is on production but behind feature flag. The MR !37574 (merged) adds explicit documentation about this and how to enable the feature flag. Should we consider this closed or wait for the FF to be enabled by default?
- Author Contributor
Not 100% sure on this one, the important one not to merge early is the release post item (if it's not actually turned on).
- Fabio Pitino added workflowproduction label and removed workflowverification label
added workflowproduction label and removed workflowverification label
- Author Contributor
@ayufan has turned this on in production, closing.
Collapse replies - Maintainer
@jyavorska It's a good call out about the "on Production with feature flag" question. Are you saying that it's fully enabled on production now (e.g. FF defaulted to enabled)?
- Author Contributor
I believe so @cheryl.li but it would be good to confirm with @ayufan if you aren't sure. That was my understanding, though.
- Maintainer
Yes. It is enabled. It is also merged into
master
to be on by default for everyone.It is yet to wait if this gonna be in %13.3. We will know that today:
- raising DAG limit to 50
- adding
()
Edited by Kamil Trzciński - Maintainer
- Maintainer
All changes are merged. They are now waiting to be acknowledged by the Delivery team that the will be part of %13.3. It is for sure for 99% at this moment, unless something really terrible happens. I will let you know once I have that confirmation. This will happen in 12-24h time at most.
- Maintainer
@cheryl.li The features will be enabled by default for %13.3. It got confirmed by Delivery team. This does mean that we are ready to merge release post items.
cc @jyavorska
Edited by Kamil Trzciński 1 - Maintainer
Yep, the release post was merged (will be sure to verify next time): gitlab-com/www-gitlab-com!57292 (merged)
/cc: @jyavorska
- Jason Yavorska closed
closed
- Jason Yavorska marked #29297 (closed) as a duplicate of this issue
marked #29297 (closed) as a duplicate of this issue
- Jason Yavorska marked this issue as related to #29297 (closed)
marked this issue as related to #29297 (closed)
- Jason Yavorska mentioned in issue #29297 (closed)
mentioned in issue #29297 (closed)
- Chance Zibolski mentioned in issue #239067 (closed)
mentioned in issue #239067 (closed)
- Marcel Amirault marked this issue as related to #238174 (closed)
marked this issue as related to #238174 (closed)