Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 35,958
    • Issues 35,958
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,292
    • Merge Requests 1,292
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #23054

Closed
Open
Opened Jul 02, 2018 by Razzeee@Razzeee

Add API endpoints for OAuth applications

Due to security concerns, it wouldn't be safe to allow wildcards for OAuth application redirects. Instead, we propose to add API endpoints to manage OAuth applications. This will allow automated systems to add/update OAuth applications with the appropriate redirect URI on the fly.

Original description

Problem to solve

Gitlab OAuth provider can only have fixed redirect uri parameters.

Further details

I'm using gitlab as a OAuth provider for my app, but I can't redirect a user to the page they are coming from. I can only redirect them to a static site which I have to set as the redirect uri in my created application.

Proposal

Add wildcards to redirect_uri somewhere around here https://gitlab.com/gitlab-org/gitlab-ce/blob/master/config/initializers/doorkeeper.rb#L105

What does success look like, and how can we measure that?

Can users set wildcards in redirect uris and do they work.

Links / references

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/config/initializers/doorkeeper.rb#L105

Edited Jun 15, 2020 by Drew Blessing
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gitlab-org/gitlab#23054