Review apps failing due to GITALY_SERVER_VERSION using SHA
From slack - June 2020 https://gitlab.slack.com/archives/CMA7DQJRX/p1591064502369700
`@ashmckenzie`: the format of gitaly tags should only be v<Major>.<Minor>.<Patch> going forward, vd08b7024a0a2882dc55d8a480d891fc0ded5bb9b should not have needed to have been created.
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/33530 updated GITALY_SERVER_VERSION from d08b7024a0a2882dc55d8a480d891fc0ded5bb9b to 13.1.0-rc2 :slightly_smiling_face:
`@rymai`: I think the problem is that we don’t handle non semver versions when deploying Review Apps: https://gitlab.com/gitlab-org/gitlab/-/blob/971aa13b289bf64e2387d9dd49e674e1a786e412/scripts/review_apps/review-apps.sh#L272 but the image is correctly tagged without the v prefix: https://gitlab.com/gitlab-org/gitlab/-/blob/971aa13b289bf64e2387d9dd49e674e1a786e412/scripts/trigger-build#L194.
This is happening again now, since 10 July 2020, where @gitlab-release-tools-bot has been updating the file with the sha. https://gitlab.com/gitlab-org/gitlab/-/commits/master/GITALY_SERVER_VERSION
I'm not sure what is the expected format of GITALY_SERVER_VERSION
.