Deprecate and remove SAST_ANALYZER_IMAGE_PREFIX and DS_ANALYZER_IMAGE_PREFIX in the Security templates
Follow up of !28617 (comment 319759132) We can't remove a var without deprecating it first. This issue is to make sure we don't forget to deprecate the var, and clean-up https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/templates/Security/SAST.gitlab-ci.yml once removed (replace with SECURE_ANALYZERS_PREFIX).
Related Links
Deprecation release post: gitlab-com/www-gitlab-com!49202 (merged)
Implementation Plan
-
Update SAST vendored template to no longer use
SAST_ANALYZER_IMAGE_PREFIX
-
Update Dependency Scanning vendored template to no longer use
DS_ANALYZER_IMAGE_PREFIX
- Update SAST documentation to not reference deprecated variable.
- Update Dependency Scanning vendored template to no longer use deprecated variable.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Philippe Lafoucrière mentioned in merge request !28617 (merged)
mentioned in merge request !28617 (merged)
- Maintainer
Same goes with
DS_ANALYZER_IMAGE_PREFIX
, that is ~"Category:Dependency Scanning". Collapse replies - Author Developer
Let's do both at the same time, it makes more sense. Thanks!
1
- Philippe Lafoucrière changed title from Deprecate and remove SAST_ANALYZER_IMAGE_PREFIX in the SAST template to Deprecate and remove {+
SAST_ANALYZER_IMAGE_PREFIX
andDS_ANALYZER_IMAGE_PREFIX
in the Security templates+}changed title from Deprecate and remove SAST_ANALYZER_IMAGE_PREFIX in the SAST template to Deprecate and remove {+
SAST_ANALYZER_IMAGE_PREFIX
andDS_ANALYZER_IMAGE_PREFIX
in the Security templates+} - Maintainer
@plafoucriere Here are a few more labels!
1 - Fabien Catteau changed title from Deprecate and remove {-
SAST_ANALYZER_IMAGE_PREFIX
andDS_ANALYZER_IMAGE_PREFIX
-} in the Security templates to Deprecate and remove SAST_ANALYZER_IMAGE_PREFIX and DS_ANALYZER_IMAGE_PREFIX in the Security templateschanged title from Deprecate and remove {-
SAST_ANALYZER_IMAGE_PREFIX
andDS_ANALYZER_IMAGE_PREFIX
-} in the Security templates to Deprecate and remove SAST_ANALYZER_IMAGE_PREFIX and DS_ANALYZER_IMAGE_PREFIX in the Security templates - Taylor McCaslin changed milestone to %13.1
changed milestone to %13.1
- Developer
Collapse replies - Developer
Roger that. This one looks to be straightforward, so I'm not overly concerned about working it in that iteration.
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- Thomas Woodham added SAST: Common Need workflowplanning breakdown labels
added SAST: Common Need workflowplanning breakdown labels
- Taylor McCaslin created merge request !31504 (closed) to address this issue
created merge request !31504 (closed) to address this issue
- Taylor McCaslin mentioned in merge request !31504 (closed)
mentioned in merge request !31504 (closed)
- Taylor McCaslin mentioned in merge request gitlab-com/www-gitlab-com!49202 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!49202 (merged)
- Taylor McCaslin added to epic &3246 (closed)
added to epic &3246 (closed)
- Taylor McCaslin changed the description
Compare with previous version changed the description
- Taylor McCaslin mentioned in merge request !31378 (merged)
mentioned in merge request !31378 (merged)
- Thomas Woodham changed the description
Compare with previous version changed the description
- Developer
Given the body of work identified in the implementation plan, this looks like our reference issues with a weight of 3.
- Thomas Woodham added Deliverable workflowready for development labels and removed workflowplanning breakdown label
added Deliverable workflowready for development labels and removed workflowplanning breakdown label
- Thomas Woodham set weight to 3
set weight to 3
- Lucas Charles assigned to @theoretick
assigned to @theoretick
- Lucas Charles added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Lucas Charles mentioned in commit 6a4ee634
mentioned in commit 6a4ee634
- Lucas Charles mentioned in merge request !34325 (merged)
mentioned in merge request !34325 (merged)
- Lucas Charles mentioned in commit e36ab727
mentioned in commit e36ab727
- Lucas Charles added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- 🤖 GitLab Bot 🤖 removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- Lucas Charles mentioned in commit b91d608e
mentioned in commit b91d608e
- Lucas Charles mentioned in commit 40f90be9
mentioned in commit 40f90be9
- Lucas Charles mentioned in commit e12b9fc1
mentioned in commit e12b9fc1
- Lucas Charles marked the checklist item Update SAST vendored template to no longer use
SAST_ANALYZER_IMAGE_PREFIX
as completedmarked the checklist item Update SAST vendored template to no longer use
SAST_ANALYZER_IMAGE_PREFIX
as completed - Lucas Charles marked the checklist item Update Dependency Scanning vendored template to no longer use
DS_ANALYZER_IMAGE_PREFIX
as completedmarked the checklist item Update Dependency Scanning vendored template to no longer use
DS_ANALYZER_IMAGE_PREFIX
as completed - Lucas Charles marked the checklist item Update SAST documentation to not reference deprecated variable. as completed
marked the checklist item Update SAST documentation to not reference deprecated variable. as completed
- Lucas Charles marked the checklist item Update Dependency Scanning vendored template to no longer use deprecated variable. as completed
marked the checklist item Update Dependency Scanning vendored template to no longer use deprecated variable. as completed
- Maintainer
- Lucas Charles closed
closed