Move features to core: "Canary Deployments"
Overview
As part of an effort to open source some currently paid features and move them to our free tier "Canary Deployments" have been identified as a feature worth moving down.
Proposal
Canary deployments should be moved to Core. This requires the removal of any licensing checks for the feature which is currently in the Premium tier.
Parts :
- CANARY_ENABLED in Auto DevOps. Already in core, just like incremental rollouts
- "canary deploy boards" aka the "yellow dot" in deploy boards.
- Advanced traffic control with Canary Ingress
Documentation
Documentation for this feature should be updated to reflect that this is no longer in a paid tier.
- Documentation: https://docs.gitlab.com/ee/user/project/canary_deployments.html
- Issue that implemented: #1659 (closed)
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Viktor Nagy (GitLab) assigned to @nagyv-gitlab
assigned to @nagyv-gitlab
- Xiaohe Li added 1 deleted label
added 1 deleted label
- Developer
@nicholasklick There was an E-level decision to open source this feature. It's not urgent, as a result, I don't want to plan with engineering time on it. What do you think, would it be viable to invite the community to do it?
Collapse replies - Developer
I just learned that this should not be handled by gitlab-com/packaging-and-pricing/features-to-open-source-march2020~9770268
- Viktor Nagy (GitLab) unassigned @nagyv-gitlab
unassigned @nagyv-gitlab
- Xiaohe Li assigned to @kencjohnston
assigned to @kencjohnston
- Contributor
@ogolowinski - One more, this move to core was approved in this Epic. Please ensure it is prioritized appropriately.
added devopsrelease [DEPRECATED] grouprelease [DEPRECATED] labels
- Kenny Johnston unassigned @kencjohnston
unassigned @kencjohnston
- Jackie Porter changed the description
Compare with previous version changed the description
- Contributor
Added Labels
- Orit Golowinski added Category:Continuous Delivery Open Source labels
added Category:Continuous Delivery Open Source labels
- Xiaohe Li assigned to @ogolowinski
assigned to @ogolowinski
- Jackie Porter added backend needs weight workflowplanning breakdown + 1 deleted label and removed grouprelease [DEPRECATED] label
added backend needs weight workflowplanning breakdown + 1 deleted label and removed grouprelease [DEPRECATED] label
- Jackie Porter added 1 deleted label
added 1 deleted label
- Jackie Porter added Category:Release Orchestration label
added Category:Release Orchestration label
- Jackie Porter unassigned @ogolowinski
unassigned @ogolowinski
- Jackie Porter mentioned in merge request gitlab-com/www-gitlab-com!45189 (closed)
mentioned in merge request gitlab-com/www-gitlab-com!45189 (closed)
- Developer
@krasio - we are being asked to move some features in Premium down to Core. Sid would love for this to be done in 12.10, but I don't think that is realistic - can you take a look at this issue and add a weight to it?
- Jackie Porter mentioned in issue #212316 (closed)
mentioned in issue #212316 (closed)
- Jackie Porter changed the description
Compare with previous version changed the description
- Developer
here seem to be two parts: CANARY_ENABLED in Auto DevOps. This has always been in core, just like incremental rollouts, this what we will cover in this issue - updating docs to move Canary_enabled features to core.
Deploy Board functionality to visualize canary deployments. I do believe this is in EE, but I’m not very familiar with deploy boards. As for where to start: I would start by digging into the code behind the canary feature of deploy boards. It should look something like this in the FE (screenshot from docs) which will be handled in #212320 (closed)
@nagyv-gitlab - FYI
- Jackie Porter assigned to @jmeshell
assigned to @jmeshell
- Jackie Porter marked this issue as related to #212320 (closed)
marked this issue as related to #212320 (closed)
- Jackie Porter unassigned @jmeshell
unassigned @jmeshell
- Nick Klick assigned to @nicholasklick
assigned to @nicholasklick
- Nick Klick added devopsconfigure [DEPRECATED] groupconfigure [DEPRECATED] labels and removed devopsrelease [DEPRECATED] + 1 deleted label
added devopsconfigure [DEPRECATED] groupconfigure [DEPRECATED] labels and removed devopsrelease [DEPRECATED] + 1 deleted label
- Nick Klick added workflowready for development label and removed workflowplanning breakdown label
added workflowready for development label and removed workflowplanning breakdown label
- Nick Klick assigned to @serenafang and unassigned @nicholasklick
assigned to @serenafang and unassigned @nicholasklick
- Developer
@serenafang this is related to #212320 (closed)
- Thong Kuah assigned to @nicholasklick and unassigned @serenafang
assigned to @nicholasklick and unassigned @serenafang
- Developer
@jmeshell @ogolowinski this clearly seems like a Release feature now?
Collapse replies - Developer
@nicholasklick - now that we have moved ADO Deployment to Release it is, but when this was created it was not.
Also, Canary is already in Core. I suppose this is just a documentation change.
- Developer
@jmeshell thanks for the clarification.
- Developer
Anytime, I am going to transition this @ogolowinski and ~"group::progressive delivery"
- Nick Klick added devopsrelease [DEPRECATED] label and removed devopsconfigure [DEPRECATED] label
added devopsrelease [DEPRECATED] label and removed devopsconfigure [DEPRECATED] label
- Nick Klick added 1 deleted label and removed groupconfigure [DEPRECATED] label
added 1 deleted label and removed groupconfigure [DEPRECATED] label
- Nick Klick unassigned @nicholasklick
unassigned @nicholasklick
- Jackie Porter added grouprelease [DEPRECATED] label and removed Category:Release Orchestration + 1 deleted label
added grouprelease [DEPRECATED] label and removed Category:Release Orchestration + 1 deleted label
- Orit Golowinski mentioned in issue #232460 (closed)
mentioned in issue #232460 (closed)
- Contributor
backend weight:
- Having done a little work on moving big features to core I'm not really comfortable giving this a smaller weight than 3, even though I don't have much experience with this part of the codebase.
- Amy Troschinetz set weight to 3
set weight to 3
- 🤖 GitLab Bot 🤖 added sectionops label
added sectionops label
- Orit Golowinski added Category:Advanced Deployments label
added Category:Advanced Deployments label
- Orit Golowinski removed Category:Continuous Delivery label
removed Category:Continuous Delivery label
- Orit Golowinski mentioned in epic &3794 (closed)
mentioned in epic &3794 (closed)
- Orit Golowinski mentioned in issue gitlab-org/ci-cd/progressive_delivery#22 (closed)
mentioned in issue gitlab-org/ci-cd/progressive_delivery#22 (closed)
- Contributor
See #212318 (comment 429200525) to see the path that was used to move feature flags to core
- Orit Golowinski mentioned in issue gitlab-com/Product#1705 (closed)
mentioned in issue gitlab-com/Product#1705 (closed)
- Contributor
@shinya.maeda similar to the calidation you did in #212316 (comment 458758124) - can you check if canary is available in Core or not?
Docs say premium https://docs.gitlab.com/ee/user/project/canary_deployments.html
Collapse replies - Maintainer
@ogolowinski Some canary related features are premium. We have to move it to core.
Off the top of my head, this is easy task, maybe weight 1-2.
- Maintainer
@shinya.maeda I am not wrong, the canary part of deploy boards is being moved to core already in !47147 (merged)
1 - Maintainer
@tkuah Ah, cool
1 - Contributor
@tkuah @shinya.maeda thanks! so, if deploy boards move to core , what is left to move to core in terms of canary?
- Maintainer
AFAIK, we have two things, both of which are being handled in !47147 (merged). /cc @tigerwnz
- "canary deploy boards" aka the "yellow dot" in deploy boards.
- Advanced traffic control with Canary Ingress
1 1 - Maintainer
Thanks Thong, you're correct - canary deploy boards were so closely linked that it made sense to move them along with "normal" deploy boards. Advanced traffic control has been moved already in !48836 (merged) (though isn't very helpful without !47147 (merged) as any changes aren't yet visualised).
- Thong Kuah changed the description
Compare with previous version changed the description
- Thong Kuah changed milestone to %13.8
changed milestone to %13.8
- Thong Kuah assigned to @tigerwnz and unassigned @kbychu
- Tiger Watson closed
closed
- Orit Golowinski mentioned in merge request gitlab-com/www-gitlab-com!69807 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!69807 (merged)