Skip to content

Geo Nodes - Conditional Removal Button

Zack Cuddy requested to merge 9682-disable-remove-primary into master

What does this MR do?

Closes #9682 (closed)

In Geo, you cannot remove the primary node without deleting the Secondary nodes. However, the UI does not reflect this. This MR adds a disabled check for the Removal button to disable removing a Primary node if Secondary nodes still exist.

A tooltip will pop up explaining the disabled button.

The positioning of the buttons was also moved to be inline with the top right of the card.

I also had to tweak a little bit of the scss file for some breakpoint changes and a wrapper for the tooltip.

Screenshots

Desktop Mobile Tooltip
before Screen_Shot_2020-03-23_at_11.01.04_AM Screen_Shot_2020-03-23_at_11.01.19_AM NULL
after Screen_Shot_2020-03-23_at_12.02.51_PM Screen_Shot_2020-03-23_at_12.02.59_PM Tooltip

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

cc: @sunjungp Closes #9682 (closed)

Edited by Zack Cuddy

Merge request reports