[13.0] Remove Redundant Feature Flags in CI/CD area
Summary
When we ship a new feature, we basically implement it behind a feature flag (Flipper). However, we often forget to remove the flags (See #30228 (closed)). This issue is to clean up such redundant feature flags at this major version update - 13.0.
Impact
- Improve the maintainability/readability by dropping legacy code path.
- Improve the performance slightly as the process doesn't run a flag check. (Neglectable, I guess)
Candidates
Here is the list of relatively old feature flags and last modifiers. We should communicate with the developers who introduced the feature flag if it's truly redundant or not.
Flag Name | Last Modifier | Can remove? | Issue/MR |
---|---|---|---|
ci_project_git_depth |
@fabiopitino | ||
job_log_json |
@fabiopitino | yes | |
ci_set_project_default_git_depth |
@fabiopitino | ||
ci_resource_group |
@dosuken123 | yes | |
ci_dag_support |
@ayufan | yes | #206902 (closed) |
ci_composite_status |
@ayufan | no | |
ci_pipeline_persisted_stages |
@grzesiek | ||
fancy_pipeline_slack_notifications |
@nfriend | yes | !29969 (merged) |
ci_force_exposing_merge_request_refs |
@dosuken123 | ||
ci_limit_test_reports_size |
@ayufan | yes | |
ci_support_interruptible_pipelines |
@ayufan | yes | |
ci_pipeline_schedule_async |
@dosuken123 | yes | |
ci_pipeline_schedule_force_gc |
@dosuken123 | yes | |
ci_doom_build |
@ayufan | yes | |
ci_update_queues_for_online_runners |
@ayufan | yes | |
auto_stop_environments |
@dosuken123 | yes | |
git_push_create_all_pipelines |
@patrickbajao | ||
ci_use_merge_request_ref |
@dosuken123 | yes | |
container_registry_cleanup |
@ayufan | no | |
environments_dashboard |
@jagood | yes | |
merge_trains_parallel_pipelines |
@dosuken123 | yes | |
merge_trains_high_concurrency |
@dosuken123 | yes | |
merge_trains_medium_concurrency |
@dosuken123 | yes | |
merge_trains_api |
@dosuken123 | yes | |
container_registry_api |
@ayufan | no | |
runner_job_trace_update_interval_header |
@furkanayhan | yes | #196428 (closed) |
ci_limit_yaml_expansion |
@mbobin | yes | |
ci_pre_post_pipeline_stages |
@mbobin | yes | #211473 (closed) |
ci_expose_arbitrary_artifacts_in_mr |
@fabiopitino | yes | #34317 (closed) |
ci_parent_child_pipeline |
@fabiopitino | yes | |
ci_root_config_content |
@furkanayhan | yes | #118811 (closed) |
auto_devops_beta |
@proglottis | no | |
ci_dag_limit_needs |
@ayufan | no | |
ci_file_based_cache |
@mbobin | yes | #211477 (closed) |
ci_yaml_limit_size |
@fabiopitino | no | |
cross_project_need_artifacts |
@mbobin | yes | #197910 (closed) |
Proposal
Either
- Build a generic removal workflow like #30228 (closed)
Or
- Remove the redundant flags right away, for now.
Edited by Nathan Friend