-
- Downloads
Fix LDAP tls_options not working
The removal of the Settingslogic gem in !113040 created a regression when LDAP `tls_options` were used. It resulted in `Gitlab::config.ldap.servers.main.tls_options.cert` returning `nil` instead of the certificate. This occurred because `Gitlab::Auth::Ldap::Config#custom_tls_options` attempts to duplicate the `tls_options` Hash and symbolize the keys, but instead it altered the internal Hash representation of `GitlabSettings::Options`. Since all the keys were transformed to symbols but `GitlabSettings::Options` converts all keys to strings, the values were inaccessible. To fix this, implement a `dup` to create a copy of the internal representation. We should also consider refactoring `Gitlab::Auth::Ldap::Config`. Relates to #413017 Changelog: fixed
parent
3598a40d
No related branches found
No related tags found
-
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
Please register or sign in to comment