Skip to content
Snippets Groups Projects
Commit 93c0294c authored by charlie ablett's avatar charlie ablett :tools:
Browse files

Merge branch 'migrate_p_terraform_state_api_unique_users_to_snowplow' into 'master'

Migrate p_terraform_state_api_unique to Snowplow

See merge request !88482
parents 9d35dd72 75b10f30
No related branches found
No related tags found
1 merge request!88482Migrate p_terraform_state_api_unique to Snowplow
Pipeline #548691684 passed
---
name: route_hll_to_snowplow_phase2
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/88482
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/363562
milestone: '15.1'
type: development
group: group::product intelligence
default_enabled: false
......@@ -24,6 +24,11 @@ class State < ::API::Base
authorize! :read_terraform_state, user_project
increment_unique_values('p_terraform_state_api_unique_users', current_user.id)
if Feature.enabled?(:route_hll_to_snowplow_phase2, user_project&.namespace)
Gitlab::Tracking.event('API::Terraform::State', 'p_terraform_state_api_unique_users',
namespace: user_project&.namespace, user: current_user)
end
end
params do
......
......@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe API::Terraform::State do
RSpec.describe API::Terraform::State, :snowplow do
include HttpBasicAuthHelpers
let_it_be(:project) { create(:project) }
......@@ -25,11 +25,17 @@
context 'without authentication' do
let(:auth_header) { basic_auth_header('bad', 'token') }
it 'does not track unique event' do
it 'does not track unique hll event' do
expect(Gitlab::UsageDataCounters::HLLRedisCounter).not_to receive(:track_event)
request
end
it 'does not track Snowplow event' do
request
expect_no_snowplow_event
end
end
context 'with maintainer permissions' do
......@@ -39,6 +45,29 @@
let(:target_event) { 'p_terraform_state_api_unique_users' }
let(:expected_value) { instance_of(Integer) }
end
it 'tracks Snowplow event' do
request
expect_snowplow_event(
category: described_class.to_s,
action: 'p_terraform_state_api_unique_users',
namespace: project.namespace.reload,
user: current_user
)
end
context 'when route_hll_to_snowplow_phase2 FF is disabled' do
before do
stub_feature_flags(route_hll_to_snowplow_phase2: false)
end
it 'does not track Snowplow event' do
request
expect_no_snowplow_event
end
end
end
end
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment