Add spring support to rails/rake binstubs

- It seems to have been inadvertently removed as part of Rails 5
  upgrade: 44fef4fe

.gitlab/ci/static-analysis.gitlab-ci.yml

@@ -24,8 +24,11 @@ static-analysis:
   extends:
     - .static-analysis-base
     - .static-analysis:rules:ee-and-foss
+    - .use-pg12
   stage: test
   parallel: 4
+  variables:
+    SETUP_DB: "true"
   script:
     - run_timed_command "retry yarn install --frozen-lockfile"
     - scripts/static-analysis
@@ -35,17 +38,6 @@ static-analysis:
     paths:
       - tmp/feature_flags/
 
-static-analysis-with-database:
-  extends:
-    - .static-analysis-base
-    - .static-analysis:rules:ee-and-foss
-    - .use-pg12
-  stage: test
-  script:
-    - bundle exec rake lint:static_verification_with_database
-  variables:
-    SETUP_DB: "true"
-
 static-analysis as-if-foss:
   extends:
     - static-analysis

bin/rails

 #!/usr/bin/env ruby
+begin
+  load File.expand_path('../spring', __FILE__)
+rescue LoadError => e
+  raise unless e.message.include?('spring')
+end
 APP_PATH = File.expand_path('../config/application', __dir__)
 require_relative '../config/boot'
 require 'rails/commands'

bin/rake

 #!/usr/bin/env ruby
+begin
+  load File.expand_path('../spring', __FILE__)
+rescue LoadError => e
+  raise unless e.message.include?('spring')
+end
 require_relative '../config/boot'
 require 'rake'
 Rake.application.run

lib/tasks/lint.rake

@@ -12,13 +12,6 @@ unless Rails.env.production?
       dev:load
     ] do
       Gitlab::Utils::Override.verify!
-    end
-
-    desc "GitLab | Lint | Static verification with database"
-    task static_verification_with_database: %w[
-      lint:static_verification_env
-      dev:load
-    ] do
       Gitlab::Utils::DelegatorOverride.verify!
     end
 

scripts/static-analysis

@@ -11,7 +11,8 @@ class StaticAnalysis
     # https://github.com/browserslist/browserslist/blob/d0ec62eb48c41c218478cd3ac28684df051cc865/node.js#L329
     # warns if caniuse-lite package is older than 6 months. Ignore this
     # warning message so that GitLab backports don't fail.
-    "Browserslist: caniuse-lite is outdated. Please run next command `yarn upgrade`"
+    /Browserslist: caniuse-lite is outdated. Please run next command `yarn upgrade`/,
+    /Running via Spring preloader/
   ].freeze
 
   Task = Struct.new(:command, :duration) do
@@ -133,8 +134,10 @@ class StaticAnalysis
   end
 
   def warning_count(static_analysis)
-    static_analysis.warned_results
-      .count { |result| !ALLOWED_WARNINGS.include?(result.stderr.strip) }
+    static_analysis.warned_results.count do |result|
+      # Return false if this result matches any of the allowed warnings
+      ALLOWED_WARNINGS.none? { |allowed_warning| result.stderr.strip =~ allowed_warning }
+    end
   end
 
   def tasks_to_run(node_total)