-
- Downloads
Add new jsonb column to store settings for default branch protection
Currently, the options for default branch protection at the instance and group level lag behind, and are not as fine-grained, as the options available from the Protected Branches feature The branch defaults lag behind because the current implementation uses an integer column to store the default settings, which becomes difficult to expand as new options and finer detail controls are added to the protected branches feature To offer better support of protected branches features on the default branch, we can: 1. use a jsonb column rather than an integer 2. update the settings API to accept a payload the matches the protected branches API 3. Pass those settings into the ProtecteBrancheService This commit performs step 1, by adding a new `jsonb` column Changelog: added
parent
77b79ac2
No related branches found
No related tags found
Showing
- app/models/application_setting.rb 7 additions, 0 deletionsapp/models/application_setting.rb
- app/models/namespace_setting.rb 7 additions, 0 deletionsapp/models/namespace_setting.rb
- app/validators/json_schemas/default_branch_protection_defaults.json 76 additions, 0 deletions...tors/json_schemas/default_branch_protection_defaults.json
- db/migrate/20230606124754_add_default_branch_protections_json_to_application_settings.rb 7 additions, 0 deletions...efault_branch_protections_json_to_application_settings.rb
- db/migrate/20230606124854_add_default_branch_protections_json_to_namespace_settings.rb 7 additions, 0 deletions..._default_branch_protections_json_to_namespace_settings.rb
- db/migrate/20230606124855_add_size_constraint_to_namespace_settings_json.rb 16 additions, 0 deletions...6124855_add_size_constraint_to_namespace_settings_json.rb
- db/migrate/20230606124856_add_size_constraint_to_application_settings_json.rb 16 additions, 0 deletions...24856_add_size_constraint_to_application_settings_json.rb
- db/schema_migrations/20230606124754 1 addition, 0 deletionsdb/schema_migrations/20230606124754
- db/schema_migrations/20230606124854 1 addition, 0 deletionsdb/schema_migrations/20230606124854
- db/schema_migrations/20230606124855 1 addition, 0 deletionsdb/schema_migrations/20230606124855
- db/schema_migrations/20230606124856 1 addition, 0 deletionsdb/schema_migrations/20230606124856
- db/structure.sql 8 additions, 0 deletionsdb/structure.sql
- spec/db/schema_spec.rb 4 additions, 3 deletionsspec/db/schema_spec.rb
- spec/models/application_setting_spec.rb 40 additions, 0 deletionsspec/models/application_setting_spec.rb
- spec/models/namespace_setting_spec.rb 45 additions, 0 deletionsspec/models/namespace_setting_spec.rb
db/schema_migrations/20230606124754
0 → 100644
db/schema_migrations/20230606124854
0 → 100644
db/schema_migrations/20230606124855
0 → 100644
db/schema_migrations/20230606124856
0 → 100644
-
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
Please register or sign in to comment