-
- Downloads
Fix participants detection for system notes
Contributes to #409006 **Problem** Previously we implemented an optimization to improve the performance of participants detection. Merge request: !98116 Instead of checking permissions for each element on the page, we started checking permissons for issuable object (issue, merge request, epic). However, this approach doesn't work well for system notes. System note requires a permission check on Note object itself. Checking it on issuable will skip the verification for system note content. **Solution** Fallback to verifying permissions for system notes on Note objects. Changelog: fixed
parent
63b08fd1
No related branches found
No related tags found
Showing
- app/models/concerns/issuable.rb 1 addition, 0 deletionsapp/models/concerns/issuable.rb
- spec/graphql/resolvers/users/participants_resolver_spec.rb 44 additions, 23 deletionsspec/graphql/resolvers/users/participants_resolver_spec.rb
- spec/support/shared_examples/models/concerns/participable_shared_examples.rb 9 additions, 2 deletions..._examples/models/concerns/participable_shared_examples.rb
-
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
Please register or sign in to comment