-
- Downloads
Refactor streaming audit headers
This change is prep work for [issues 366350][0] We want to emit audit events whenever the custom streaming event headers are creating/updated/destroyed We have decided to refactor the existing logic into [service classes][1], and then add then add the actual audit events using [this method][2]. I put the services under `ee/app/services` because the custom http header feature is [only available in EE gitlab][3] This first commit is **only** a refactor, so the existing specs have not been touched and the actual audit event work is not included in this commit [0]:#366350 [1]:https://docs.gitlab.com/ee/development/reusing_abstractions.html#service-classes [2]:https://docs.gitlab.com/ee/development/audit_event_guide/#using-standard-method-call-to-record-single-event [3]:https://docs.gitlab.com/ee/development/ee_features.html#ee-only-features
Showing
- ee/app/graphql/mutations/audit_events/streaming/headers/create.rb 16 additions, 8 deletions...raphql/mutations/audit_events/streaming/headers/create.rb
- ee/app/graphql/mutations/audit_events/streaming/headers/destroy.rb 11 additions, 6 deletions...aphql/mutations/audit_events/streaming/headers/destroy.rb
- ee/app/graphql/mutations/audit_events/streaming/headers/update.rb 16 additions, 9 deletions...raphql/mutations/audit_events/streaming/headers/update.rb
- ee/app/services/audit_events/streaming/headers/base.rb 34 additions, 0 deletionsee/app/services/audit_events/streaming/headers/base.rb
- ee/app/services/audit_events/streaming/headers/create_service.rb 22 additions, 0 deletions...services/audit_events/streaming/headers/create_service.rb
- ee/app/services/audit_events/streaming/headers/destroy_service.rb 27 additions, 0 deletions...ervices/audit_events/streaming/headers/destroy_service.rb
- ee/app/services/audit_events/streaming/headers/update_service.rb 27 additions, 0 deletions...services/audit_events/streaming/headers/update_service.rb
- ee/spec/services/audit_events/streaming/headers/base_spec.rb 38 additions, 0 deletionsee/spec/services/audit_events/streaming/headers/base_spec.rb
- ee/spec/services/audit_events/streaming/headers/create_service_spec.rb 38 additions, 0 deletions...ces/audit_events/streaming/headers/create_service_spec.rb
- ee/spec/services/audit_events/streaming/headers/destroy_service_spec.rb 42 additions, 0 deletions...es/audit_events/streaming/headers/destroy_service_spec.rb
- ee/spec/services/audit_events/streaming/headers/update_service_spec.rb 49 additions, 0 deletions...ces/audit_events/streaming/headers/update_service_spec.rb
Loading
Please register or sign in to comment