Skip to content
Snippets Groups Projects
Select Git revision
  • kassio/graphql-dynamically-list-work-item-types
  • 524333-ai-job-toubleshoot-ch
  • tutorial-duo-errors
  • master default protected
  • 521630-add-app-settings-for-pep-limits
  • 501553-add-admin-role-dropdown-to-user-edit-page
  • 501553-add-selected-user-type-descriptions-to-card
  • rails-next protected
  • ruby-next protected
  • morefice/configurable-reindexing
  • ag/512069-before-submit-hook
  • remove-unused-spotbugs-rule
  • 533911-prevent-test-cases-from-opening-in-work-item-contextual-view-drawer
  • andrey-update-cache-job-image
  • 502767-drop-index
  • 457219_stop_stale_request_promotions
  • ch_503812-2
  • djadmin-inventory-keyset-pagination
  • 501553-add-ability-to-save-admin-role-from-form
  • bm/upgrade-attr-encrypted
  • v17.10.3-ee protected
  • v17.9.5-ee protected
  • v17.10.2-ee protected
  • v17.9.4-ee protected
  • v17.8.6-ee protected
  • v17.9.3-ee protected
  • v17.10.1-ee protected
  • v17.10.0-ee protected
  • v17.10.0-rc42-ee protected
  • v17.7.7-ee protected
  • v17.8.5-ee protected
  • v17.9.2-ee protected
  • v17.7.6-ee protected
  • v17.8.4-ee protected
  • v17.9.1-ee protected
  • v17.8.3-ee protected
  • v17.7.5-ee protected
  • v17.9.0-ee protected
  • v17.9.0-rc42-ee protected
  • v17.6.5-ee protected
40 results

20230830084959

  • Vasilii Iakliushin's avatar
    11907981
    Increase the string limits for regex fields in push_rules · 11907981
    Vasilii Iakliushin authored
    Contributes to gitlab-org/gitlab#423445
    
    **Problem**
    
    We have a discrepancy between GitLab database and `db/structure.sql`.
    GitLab database contains 255 character limit for regex fields. But this
    limit is missing for self-hosted instances and GDK.
    
    **Solution**
    
    Recently we added a Rails validation to prevent regex longer than 511
    characters (gitlab-org/gitlab!128153).
    
    We can migrate existing columns to match this limit.
    
    It's a three step migration:
    
    1. Add NOT VALID CHECK to verify length of regex fields
    2. Validate regex fields
    3. Remove any char limits from regex fields
    
    Changelog: changed
    EE: true
    11907981
    History
    Increase the string limits for regex fields in push_rules
    Vasilii Iakliushin authored
    Contributes to gitlab-org/gitlab#423445
    
    **Problem**
    
    We have a discrepancy between GitLab database and `db/structure.sql`.
    GitLab database contains 255 character limit for regex fields. But this
    limit is missing for self-hosted instances and GDK.
    
    **Solution**
    
    Recently we added a Rails validation to prevent regex longer than 511
    characters (gitlab-org/gitlab!128153).
    
    We can migrate existing columns to match this limit.
    
    It's a three step migration:
    
    1. Add NOT VALID CHECK to verify length of regex fields
    2. Validate regex fields
    3. Remove any char limits from regex fields
    
    Changelog: changed
    EE: true
Code owners
Assign users and groups as approvers for specific file changes. Learn more.