Auto-register Prometheus metrics
- Update to latest upstream Prometheus library.
- Update to latest upstream Prometheus gRPC library.
- Switch to
promauto
package to avoid missing metrics.
Closes: #326 (closed)
Signed-off-by: Ben Kochie bjk@gitlab.com
Merge request reports
Activity
added 2 commits
- Resolved by Ben Kochie
- Resolved by Ben Kochie
Thanks @bjk-gitlab !
@patrickbajao WDYT?
assigned to @patrickbajao and unassigned @mkaeppler
- Resolved by Patrick Bajao
assigned to @bjk-gitlab and unassigned @patrickbajao
added 8 commits
-
33ed0166...e1254d74 - 7 commits from branch
master
- 35403c6c - Auto-register Prometheus metrics
-
33ed0166...e1254d74 - 7 commits from branch
assigned to @patrickbajao and unassigned @bjk-gitlab
- Resolved by Patrick Bajao
Note, I have removed
gitlab_workhorse_object_storage_upload_bytes
. This (incorrectly named) counter is registered, but never used, so the values are always zero.I noticed there are a number of issues with Prometheus naming conventions. We should probably open a separate issue to fix them.
For example:
gitlab_workhorse_object_storage_upload_time
should begitlab_workhorse_object_storage_upload_duration_seconds
.
mentioned in issue gitlab#249637 (closed)
- Resolved by Ben Kochie
- Resolved by Ben Kochie
assigned to @bjk-gitlab and unassigned @patrickbajao
mentioned in issue #327 (moved)
assigned to @patrickbajao and unassigned @bjk-gitlab
- Resolved by Ben Kochie
- Resolved by Patrick Bajao
@bjk-gitlab thanks for making the changes and they LGTM.
There are conflicts withmaster
though. Can you please rebase? Please assign it back to me so I can merge.
assigned to @bjk-gitlab and unassigned @patrickbajao
added 13 commits
-
d7e07e91...35047496 - 12 commits from branch
master
- fa659fc3 - Auto-register Prometheus metrics
-
d7e07e91...35047496 - 12 commits from branch
assigned to @patrickbajao
enabled automatic add to merge train when the pipeline for 7ebd03dd succeeds
mentioned in commit 5b34783e
mentioned in commit gitlab@99fba74a
mentioned in merge request gitlab!49534 (merged)
mentioned in issue gitlab#324828