Skip to content
Snippets Groups Projects

Auto-register Prometheus metrics

Merged Ben Kochie requested to merge bjk/fix_metrics into master
All threads resolved!
  • Update to latest upstream Prometheus library.
  • Update to latest upstream Prometheus gRPC library.
  • Switch to promauto package to avoid missing metrics.

Closes: #326 (closed)

Signed-off-by: Ben Kochie bjk@gitlab.com

Edited by Ben Kochie

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @patrickbajao and unassigned @mkaeppler

  • Ben Kochie added 3 commits

    added 3 commits

    Compare with previous version

  • Ben Kochie changed title from Update http metrics to Auto-register Prometheus metrics

    changed title from Update http metrics to Auto-register Prometheus metrics

  • Ben Kochie added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Kochie resolved all threads

    resolved all threads

  • assigned to @bjk-gitlab and unassigned @patrickbajao

  • Ben Kochie added 8 commits

    added 8 commits

    Compare with previous version

  • Ben Kochie resolved all threads

    resolved all threads

  • Ben Kochie assigned to @patrickbajao and unassigned @bjk-gitlab

    assigned to @patrickbajao and unassigned @bjk-gitlab

  • Author Contributor

    I dropped the metric removal and added all instances of converting MustRegister to promauto.

  • Ben Kochie added 1 commit

    added 1 commit

    • a2bc2f4b - Auto-register Prometheus metrics

    Compare with previous version

  • Ben Kochie added 1 commit

    added 1 commit

    • be3c45d1 - Auto-register Prometheus metrics

    Compare with previous version

    • Author Contributor
      Resolved by Patrick Bajao

      Note, I have removed gitlab_workhorse_object_storage_upload_bytes. This (incorrectly named) counter is registered, but never used, so the values are always zero.

      I noticed there are a number of issues with Prometheus naming conventions. We should probably open a separate issue to fix them.

      For example: gitlab_workhorse_object_storage_upload_time should be gitlab_workhorse_object_storage_upload_duration_seconds.

  • Patrick Bajao
  • assigned to @bjk-gitlab and unassigned @patrickbajao

  • mentioned in issue #327 (moved)

  • Ben Kochie added 1 commit

    added 1 commit

    • 2caaafca - Auto-register Prometheus metrics

    Compare with previous version

  • Ben Kochie added 1 commit

    added 1 commit

    • d7e07e91 - Auto-register Prometheus metrics

    Compare with previous version

  • Ben Kochie resolved all threads

    resolved all threads

  • Author Contributor

    Ok, I think I fixed the objectstorage upload bytes metric.

  • Ben Kochie assigned to @patrickbajao and unassigned @bjk-gitlab

    assigned to @patrickbajao and unassigned @bjk-gitlab

  • Ben Kochie
  • Patrick Bajao resolved all threads

    resolved all threads

  • assigned to @bjk-gitlab and unassigned @patrickbajao

  • Patrick Bajao added 13 commits

    added 13 commits

    Compare with previous version

  • Patrick Bajao approved this merge request

    approved this merge request

  • Patrick Bajao resolved all threads

    resolved all threads

  • Patrick Bajao enabled automatic add to merge train when the pipeline for 7ebd03dd succeeds

    enabled automatic add to merge train when the pipeline for 7ebd03dd succeeds

  • Patrick Bajao started a merge train

    started a merge train

  • Patrick Bajao mentioned in commit 5b34783e

    mentioned in commit 5b34783e

  • merged

  • Stan Hu mentioned in commit gitlab@99fba74a

    mentioned in commit gitlab@99fba74a

  • Stan Hu mentioned in merge request gitlab!49534 (merged)

    mentioned in merge request gitlab!49534 (merged)

  • mentioned in issue gitlab#324828

  • Please register or sign in to reply
    Loading