Skip to content

Fix TestAccessLogFormatter_Format timezone dependency

Alessio Caiazza (OOO until 2024-08-26) requested to merge fix/TestAccessLogFormatter_Format into master

TestAccessLogFormatter_Format depends on computer timezone, this patch fill force an UTC time during the test.

--- FAIL: TestAccessLogFormatter_Format (0.00s)
    --- FAIL: TestAccessLogFormatter_Format/blank (0.00s)
        Error Trace:    accesslogformatter_test.go:54
    	Error:		Not equal:
    			expected: "-  - - [2018/01/07:00:00:00 +0000] \"  \" 0 0 \"\" \"\" 0.000\n"
    			received: "-  - - [2018/01/07:01:00:00 +0100] \"  \" 0 0 \"\" \"\" 0.000\n"

    --- FAIL: TestAccessLogFormatter_Format/full (0.00s)
        Error Trace:    accesslogformatter_test.go:54
    	Error:		Not equal:
    			expected: "gitlab.com 127.0.0.1 - - [2018/01/07:00:00:00 +0000] \"GET / HTTP/1.1\" 200 100 \"http://localhost\" \"Mozilla/1.0\" 5.000\n"
    			received: "gitlab.com 127.0.0.1 - - [2018/01/07:01:00:00 +0100] \"GET / HTTP/1.1\" 200 100 \"http://localhost\" \"Mozilla/1.0\" 5.000\n"

time="2018-03-07T09:00:06+01:00" level=error msg="unknown error" error="<nil>"
FAIL
FAIL	gitlab.com/gitlab-org/gitlab-workhorse/internal/helper	0.040s

Merge request reports