Update VSCode to 1.93.1
Issue Update VSCode submodule to 1.93.1 (#48 - closed)
What does this MR do?
- It bumps the VSCode submodule version to 1.93.1. !108 (0eb76052)
- It adapts the customization patches after the version bump. !108 (7d308469)
-
breaking change It uses a new Docker image with a newer version of Node.js (from 18.x to 22.x). It also uses a
saas-linux-medium-amd64hosted runner machine with more RAM and CPU resources because thebuild-webandbuild-serverjobs failed with the defaultsaas-linux-small-amd64machine !108 (2b2dd53b). - It fixes a bug in the
dev-apply-patchesscript where the script won't resume applying the patch files after running into a merge conflict !108 (ae132ffa).
Breaking changes
Build
- VSCode requires a new Node.js version, 20.x or newer.
Web IDE
- Replaced
vscode/out/vs/workbench/workbench.web.main.nls.jswithvscode/out/nls.messages.js. - Replaced hardcoded
node_modulespaths withbundled_node_modulesgitlab-web-ide!394 (diffs).
Exploratory testing
| Product | Demo | Build artifact | Exploratory Testing MR |
|---|---|---|---|
| Workspaces | workspaces_exploratory_testing.mov | registry.gitlab.com/gitlab-org/workspaces/gitlab-workspaces-tools:dev-20241213164356 | gitlab-org/workspaces/gitlab-workspaces-tools!18 (merged) |
| Web IDE | web_ide_exploratory_testing.mov | https://gitlab.com/gitlab-org/gitlab-web-ide-vscode-fork/-/jobs/8624105634/artifacts/raw/.build/vscode-web-dist/vscode-web-1.93.1-1.0.0-dev-20241212131304.tar.gz |
gitlab-web-ide!394 (merged) |
Edited by Enrique Alcántara