refactor(security_scanning): Resolve outdated security finding type names
Description
Follow-up to !1326 (comment 1721234931)
Now that we access the entire findingReportsComparer
field, we should update the type definition name and usages to reflect it.
Related Issues
Resolves Refactor type GqlSecurityFindingReport to type ... (#1238 - closed).
How has this been tested?
-
Check out the branch in this MR 1238-refactor-graphql-finding-report
for the gitlab-vscode-extension -
Clone the https://gitlab.com/gitlab-org/frontend/playground/gitlab-mr-widgets-demo project locally -
Check out the vs-code-security-reports-retest-2
branch from the MR -
Open in vs-code the the gitlab-mr-widgets-demo
directory, verify the current checked out branch ismain-patch-cf9d-branched
-
Open the gitlab extension and observe the UI going through state changes as the pipeline runs and completes
Screenshots (no visual changes due to refactor only)
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to change) -
Documentation -
Chore (Related to CI or Packaging to platforms) -
Test gap
Edited by Erran Carey