Avatar images are broken with self-hosted GitLab
Checklist
-
I'm using the latest version of the extension (see the latest version in the right column of this page) - Extension version: v4.9.0
-
I'm using the latest VS Code version (find the latest version here) - VS Code version:
Version: 1.88.1 (Universal)
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
Date: 2024-04-10T17:42:52.765Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin arm64 23.4.0
-
I'm using a supported version of GitLab (see README for the supported version) - GitLab version: I'm not sure because I don't maintain it, but it's pretty recent I think (our org is pretty rigorous about updates)
Summary
When loading a discussion thread in a MR in the extension, no avatars are displayed (other features work). In the dev console, the avatar requests are all returning 401 Unauthorized. This is similar to #153 (closed), #305 but in my case the connection is HTTPS.
Steps to reproduce
Just guessing because I don't have the time to set up a brand new instance to check but:
- Set up self-hosted GitLab. Potentially there's some additional security setting that is needed to make uploaded images require authorization as well (but my guess is that's always the case?)
- Create an avatar for a user.
- Create a discussion with that user.
- Try to view it in the extension.
What is the current bug behavior?
Broken images where avatars should be
What is the expected correct behavior?
Avatar images load successfully (with authentication if necessary)
Relevant logs and/or screenshots
Possible fixes
Edited by Tyler Brandt