fix(GlIntersperse): Ignore empty nodes in Vue 3

Miguel Rinconrequested to merge
3009-glintersperse-renders-extra-separators-for-conditional-elements-in-vue-3 into main

What does this MR do?

This change fixes an issue in the intersperse component when it contains Vue 3 fragments or elements that are not rendered, such as when v-if evaluates to false.

This should fix some failures in our GitLab repo tests in Vue 3 (see !4836 (comment 2220279160)). I found this issue in the GitLab repo at runner_details_spec.js.

My issue tracking this effort at gitlab#503489 (closed).

Technical info

  • Intersperse logic is different between Vue versions, so we detect the Vue version to apply the right logic.
  • We check for Vue 3 fragments, if we find them, we ensure their children get interspersed individually.
  • We clean up empty nodes using the now public isVnodeEmpty (previously private) which already has some mileage and tests.

Screenshots or screen recordings

NA

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #3009 (closed)

Edited by Miguel Rincon

Merge request reports