Skip to content

feat(Drawer): Update design tokens

What does this MR do?

Update design tokens used in the drawer component to align with design direction for dark mode.

  • Use overlap for background to offset from default page background, similar to modal.
  • Use default for borders.

Note: There should be no apparent visual changes to light mode, even if design tokens have been updated.

Screenshots or screen recordings

📷 Before and after screenshots
Before After
CleanShot_2024-11-04_at_16.25.56_2x CleanShot_2024-11-04_at_16.39.30_2x
CleanShot_2024-11-04_at_16.26.15_2x CleanShot_2024-11-20_at_08.39.15_2x
CleanShot_2024-11-04_at_16.45.56_2x CleanShot_2024-11-04_at_16.44.42_2x
CleanShot_2024-11-04_at_16.46.19_2x CleanShot_2024-11-20_at_08.39.40_2x

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Relates to: gitlab-org/gitlab-services/design.gitlab.com#1886 (closed)

Edited by Jeremy Elder

Merge request reports

Loading