Skip to content

Add click and focusin event types in Base Dropdown (opt-in)

Vanessa Otto requested to merge 1995-investigate-listening-for-focusin-events-in-gloutsidedirective-3 into main

What does this MR do?

The changes of this MR add on to the changes of !4275 (merged) where we added the event type focusin to the v-outside directive. In this MR, I applied the event type to the BaseDropdown component which uses this directive. The components GlDisclosureDropdown and GlCollapsibleListbox use BaseDropdown. The three components now accept the optional property outsideEventTypes, with an empty array as default value. The directive applies the click event listener by default if no value is set.

Once the changes are done, we can configure some dropdowns in GitLab to listen to click and focusin to fix gitlab#426761.

Screenshots or screen recordings

Screen_Recording_2024-07-09_at_16.24.22

Screen_Recording_2024-07-09_at_16.22.37

Screen recording Archive

This was a state in between:

🎧 Sound on

output

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Relates to #1995 (closed)

Edited by Vanessa Otto

Merge request reports