Skip to content

Add focusin event type in Outside Directive

Vanessa Otto requested to merge 1995-investigate-listening-for-focusin-events-in-gloutsidedirective into main

What does this MR do?

This MR adds the event type focusin to the directive. The Directive can now be configured to listen only to click (which is the default), or to focusin, or to both click and focusin. There are multiple ways to register the directive. You can find them on the documentation page of the directive under http://localhost:9001/?path=/docs/directives-outside-directive--docs#summary-of-usage. The changes are backwards compatible and have no breacking changes, as the "old" or "simple" way of registering a click listener using the directive is still supported.

In !4299 (merged) I added focusin to the components GlDisclosureDropdown and GlCollapsibleListbox

Screenshots or screen recordings

Click and focusin use cases testing { capture: true }

🎧 sound on

output

Updating the value of the directive

🎧 sound on

Screen_Recording_2024-06-20_at_11.00.01

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Related to #1995 (closed)

Edited by Vanessa Otto

Merge request reports