Skip to content

Filtered search dropdowns: default focus to first item

Chad Lavimoniere requested to merge 217195-filtered-search-preselect-first-suggestion into main

What does this MR do?

This MR changes the default behavior of filtered_search_suggestion_list.vue so that when there is no match for an initial value from search, the first item in the list automatically gets focused. This is a followup to close gitlab#217195.

This makes token type selection (i.e., what do you want to filter on) and token value selection (i.e., what value do you want to filter on) match the experience the user has currently for token operator selection (i.e. =/!=/||).

To see the difference:

  1. Go to https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-filtered-search--default
  2. Interact with the search filter bar
  3. Check out this branch
  4. Go to http://localhost:9001/?path=/story/base-filtered-search--with-terms-as-tokens
  5. Interact with the search filter bar

You will see that when you click in the search filter bar, the first item is automatically highlighted. You can continue typing as normal, or you can use the arrow keys to move focus between items.

When you have selected a token type and a token operator, you will see that the first item in the token value dropdown is automatically highlighted.

Highlighting based on search result matching is not affected.

Screenshots or screen recordings

Before After
before after

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Relates to gitlab#217195, gitlab#444717 (closed)

Edited by Peter Hegman

Merge request reports