Skip to content

feat(GlLabel): Fix size for legacy label implementations (HAML & E-Mail)

Sascha Eggenberger requested to merge labels-support-legacy-implemenations-without-link into main

What does this MR do?

We have some legacy instances in the product of GlLabel (in HAML) which use a slightly different structure:

<span class="gl-label">
  <span class="gl-label-text gl-label-text-light" data-html="true" style="background-color:#913a90;">BBQ</span>
</span>

This leads to a small visual regression where the label would render with a wrong font-size and height. The problem was there before as we define other sizes on the root level of the component and on the link level. But now it's more prominent as the label size is slightly reduced.

It also removed the use of padding-inline and padding-block as E-Mail clients can't interpret these just yet (see https://www.caniemail.com/search/?s=padding-inline)

Screenshots or screen recordings

GlLabel GitLab UI component (no visual change)

Before After
before after

Legacy HAML implementation

Before After
before after

E-Mail implementation

Before After
before after
before2 after2

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Related to gitlab#444717 (closed), !3306 (merged), gitlab!129915 (merged)

Edited by Sascha Eggenberger

Merge request reports