Skip to content

feat(BaseDropdown): Use a "main" element boundary when available

Miguel Rinconrequested to merge
2588-proposal-let-s-add-a-boundary-to-our-dropdowns into main

What does this MR do?

BREAKING CHANGE: This change slightly alters the default positioning of GlDisclosureDropdown and GlListbox.

If the dropdown is placed inside a element: The disclosure will use main as a boundary to not overflow it. This change aims to smartly reduce the need to use custom "placement" ('right' and 'bottom-end') options, especially when the dropdown is placed on the right side, such as in contextual menus.

If the dropdown is not placed in a element, behavior does change.

Expected results

We have over ~60 contextual menus that could benefit from this change, whenever we set up a dropdown in the top-right corner of the screen, it will respond correctly without additional placements.

Screenshots or screen recordings

👀 Look ma, no placement!

image

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2588 (closed)

Edited by Jeremy Elder

Merge request reports