Skip to content

Draft: DatePicker Filter Token - investigation

Daniele Rossetti requested to merge rossetd/draft-advanced-date-picker into main

What does this MR do?

Just wanted to gather some initial feedback of this approach.

I was looking at implementing something that looks like the screenshot below. i.e. have a search token with a list of predefined options + a Custom option that is supposed to open the Date range picker to let the user select the date range.

The approach:

~~I've reused most of the logic added by @leetickett-gitlab when he initially added support for a date picker filter ( ~~~~~~~~https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests?scope=all&state=merged&author_username=leetickett-gitlab~~~~~~~~ and gitlab!120160 (merged)), and extended that with a API change ( :custom-apply-suggestion added to GlFilteredSearchToken ) to allow intercepting setting the filter value, so that we can do other stuff (e.g. show the date picker, or potentially any other component such as popup etc ) before committing the change. This works somewhat fine also when navigating the filter bar with keyboard.~~

Before cleaning this up, adding tests etc I wanted to get some feedback on this approach. Thoughts?

Note: some good discussion about accessibility here: !3837 (comment 1683711053)

Latest Update: !3837 (comment 1686696390)

Storybook: http://rossetd-draft-advanced-date-picker.34.140.25.101.nip.io/?path=/story/base-filtered-search--default

image.png

Screenshots or screen recordings

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Daniele Rossetti

Merge request reports