Skip to content

Use the gitlab-org group token for Danger

Rémy Coutable requested to merge rymai-main-patch-6eae into main

What does this MR do?

There's no need to use a different token than the one provided at the group level. I've set the DANGER_GITLAB_API_TOKEN with the value of GITLAB_TOKEN for now to keep Danger working until we resolve https://gitlab.com/gitlab-sirt/shared-incidents/incident_4468/-/issues/1 / https://gitlab.com/gitlab-com/gl-infra/production/-/issues/17012.

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Rémy Coutable

Merge request reports