Skip to content

feat(Banner): Update heading to use heading scale

Dan MH requested to merge banner-heading-styles-danmh into main

What does this MR do?

We are trying to increase results, quality, and efficiency by using typography in a systematic way.

This MR updates banner to use the heading scale implemented in !3673 (merged).

gl-heading-scale-500 is used as the semantic heading scale does not visually align (see contextual adjustments).

This MR also:

  • fixes padding that didn't align to spec
  • removes unused css

Design work:

For more context see:

Screenshots or screen recordings

Before After
gitlab-org.gitlab.io_gitlab-ui_iframe.html_args__id_base-banner--default_viewMode_story localhost_9001_iframe.html_args__id_base-banner--default_viewMode_story
gitlab-org.gitlab.io_gitlab-ui_iframe.html_args__id_base-banner--introduction_viewMode_story localhost_9001_iframe.html_args__id_base-banner--introduction_viewMode_story
gitlab-org.gitlab.io_gitlab-ui_iframe.html_args__id_base-banner--default_viewMode_story__1_ localhost_9001_iframe.html_args__id_base-banner--default_viewMode_story__1_
gitlab-org.gitlab.io_gitlab-ui_iframe.html_args__id_base-banner--introduction_viewMode_story__1_ localhost_9001_iframe.html_args__id_base-banner--introduction_viewMode_story__1_

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Jeremy Elder

Merge request reports