Skip to content

Form elements > No statefulness in Windows High Contrast Mode

What does this MR do?

  • Updates checkbox and radio button styles to ensure states are visible in Windows High Contrast Mode (WHCM).
  • There should be no visual regressions for default mode, but it does update the checkbox checkmark and dash (indeterminate) SVGs to align with icon guidelines.

Screenshots or screen recordings

👁‍🗨 Expand screenshots
Before After Notes
Checkboxes prior to code change Checkboxes after code change Updated icons.
Checkbox no states visible Checkbox visible states See note on green color below.
Radio buttons prior to code change Radio buttons after code change Updated icons. (Side note: the indeterminate options should be removed as this only supports binary states)
Radio button no states visible Radio button visible states See note on green color below.

The green in the disabled states comes from the default color in WHCM. In the CSS, this references the system color as GrayText which is used for disabled text, but also applied to the background in this MR.

CleanShot_2023-08-14_at_10.28.55_2x

Resources

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2291 (closed)

Edited by Jeremy Elder

Merge request reports