Skip to content

feat(GlFormInut, GlFormSelect, GlDatepicker): Add prop width, deprecate prop size

Sascha Eggenberger requested to merge form-input-select-replace-size-prop-with-width into main

What does this MR do?

Adds a new property width and deprecated the property size.

Why this change?

We use the prop size in a different context on most components (e.g. GlButton) to determine the actual visual size of the button. In the use case for GlFormInput, GlFormSelect & GlDropdown size only changes the length (width) of the element itself. In an attempt to unify the properties used we'll deprecate size on these components and replace it with width. This will allow us as well to introduce width to other form related components in the near future.

Screenshots or screen recordings

–

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Sascha Eggenberger

Merge request reports