feat(GlFormInut, GlFormSelect, GlDatepicker): Add prop width, deprecate prop size
Compare changes
Files
11@@ -426,4 +426,21 @@ describe('datepicker component', () => {
Adds a new property width
and deprecated the property size
.
Why this change?
We use the prop size
in a different context on most components (e.g. GlButton
) to determine the actual visual size of the button. In the use case for GlFormInput
, GlFormSelect
& GlDropdown
size
only changes the length (width) of the element itself. In an attempt to unify the properties used we'll deprecate size
on these components and replace it with width
. This will allow us as well to introduce width
to other form related components in the near future.
GlFormInput
: http://localhost:9001/?path=/docs/base-form-form-input--docs
GlFormSelect
: http://localhost:9001/?path=/docs/base-form-form-select--docs
GlDropdown
: http://localhost:9001/?path=/docs/base-datepicker--docs
–
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
~"component:*"
label(s) if applicable.If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
@gitlab-com/gl-security/appsec
If this MR adds or modifies a component, take a few moments to review the following:
aria-label
for icons that have meaning or perform actions.aria-expanded="false"
to aria-expanded="true"
when an accordion is expanded.