Skip to content

Banner use glclose

Jeremy Elder requested to merge banner-use-glclose into main

What does this MR do?

Use CloseButton in GlBanner.

  • Use the default "Dismiss" aria-label.
  • Use the default tertiary button variant instead of conditionally using confirm primary for the Introduction banner (is aligns with the design specs).
Before After
CleanShot_2023-04-11_at_11.03.17 CleanShot_2023-04-11_at_11.23.08
CleanShot_2023-04-11_at_11.03.38 CleanShot_2023-04-11_at_11.23.24
CleanShot_2023-04-11_at_11.04.04 CleanShot_2023-04-11_at_11.23.59

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • [-] Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes gitlab#365206 (closed)

Edited by Jeremy Elder

Merge request reports