Skip to content

perf(v-safe-html): Remove a small inefficiency in the directive's node clearing algorithm

Thomas Randolph requested to merge tor/performance/safe-html-directive into main

What does this MR do?

Remove a loop to unset content in the DOM node, and opting instead for setting the node's textContent to an empty string.

It's relatively slow to loop over each DOM node and remove them one-by-one.

The Fixes

el.textContent = '' is identical in practice to the loop that removes each node one-by-one.

Why

We (the groupcode review team) noticed a significant performance decrease when many parts of the DOM use v-safe-html.

While this change may not induce us to return to using that directive, it will likely improve performance in other parts of the app.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • [-] Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • [-] All actions and functionality can be done with a keyboard.
  • [-] Links, buttons, and controls have a visible focus state.
  • [-] All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • [-] Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • [-] Color combinations have sufficient contrast.
Edited by Thomas Randolph

Merge request reports