Skip to content

Remove safe HTML from diff rows

Phil Hughes requested to merge ph/diffsRemoveSafeHtmlDirective into master

What does this MR do?

Removes the use of the safe HTML directive from our diff rows to help increase performance. The data we receive from the backend comes pre-sanitized so there is no need to do this again.

With this change I have also removed some extra data being set in the state when it doesn't need to be.

Screenshots (strongly suggested)

Before After
Screenshot_2021-03-30_at_15.37.21 Screenshot_2021-03-30_at_15.37.28

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports